From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C2FBC433E0 for ; Fri, 29 May 2020 15:01:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37A4A20776 for ; Fri, 29 May 2020 15:01:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VTwxU9Yx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37A4A20776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jegW5-0005gf-6P for qemu-devel@archiver.kernel.org; Fri, 29 May 2020 11:01:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jegUJ-0004Or-FT for qemu-devel@nongnu.org; Fri, 29 May 2020 10:59:59 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:24191 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jegUI-0004ey-20 for qemu-devel@nongnu.org; Fri, 29 May 2020 10:59:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590764395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e9e1gqiCfPSvrObsjJ+FzdBTVV5oB4avoAH4F1aEDGk=; b=VTwxU9YxsnPWnpTPAcUzbXD0H0WAI/CewNuCfbnG4Yz50uPpH2TwrOsTU7gniFgc0drXC3 jN2bX14gq59adzyhSvXMHHU/gEzUJOwRS61zOkX/5zZ5i2nziBDoqh3mBlePZQqHBhE8rl nVuihzdGUVJl8Sr3/EVghHSopwBxytQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-89-I5ORXUaaO9un5OD9A2l_fA-1; Fri, 29 May 2020 10:59:52 -0400 X-MC-Unique: I5ORXUaaO9un5OD9A2l_fA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DC00C872FF5; Fri, 29 May 2020 14:59:51 +0000 (UTC) Received: from localhost (unknown [10.40.208.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 225F37A8CA; Fri, 29 May 2020 14:59:49 +0000 (UTC) Date: Fri, 29 May 2020 16:59:47 +0200 From: Igor Mammedov To: Michal Privoznik Subject: Re: [PATCH 2/3] numa: Allow HMAT cache to be defined before HMAT latency/bandwidth Message-ID: <20200529165947.36a8cf55@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/29 01:27:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jingqi.liu@intel.com, tao3.xu@intel.com, qemu-devel@nongnu.org, ehabkost@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 29 May 2020 15:33:47 +0200 Michal Privoznik wrote: > Currently, when defining a HMAT cache for a NUMA node (in > parse_numa_hmat_cache()) there is this check that forces users to > define HMAT latency/bandwidth first. There is no real need for > this, because nothing in the parse function relies on that and > the HMAT table is constructed way later - when ACPI table is > constructed. see comment in https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg01206.html in short doing check at this time allow us not to have more complex check later on. perhaps it needs a comment so that later it won't be dropped by accident > > Signed-off-by: Michal Privoznik > --- > hw/core/numa.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/hw/core/numa.c b/hw/core/numa.c > index 316bc50d75..338453461c 100644 > --- a/hw/core/numa.c > +++ b/hw/core/numa.c > @@ -384,7 +384,6 @@ void parse_numa_hmat_cache(MachineState *ms, NumaHmatCacheOptions *node, > Error **errp) > { > int nb_numa_nodes = ms->numa_state->num_nodes; > - NodeInfo *numa_info = ms->numa_state->nodes; > NumaHmatCacheOptions *hmat_cache = NULL; > > if (node->node_id >= nb_numa_nodes) { > @@ -393,13 +392,6 @@ void parse_numa_hmat_cache(MachineState *ms, NumaHmatCacheOptions *node, > return; > } > > - if (numa_info[node->node_id].lb_info_provided != (BIT(0) | BIT(1))) { > - error_setg(errp, "The latency and bandwidth information of " > - "node-id=%" PRIu32 " should be provided before memory side " > - "cache attributes", node->node_id); > - return; > - } > - > if (node->level < 1 || node->level >= HMAT_LB_LEVELS) { > error_setg(errp, "Invalid level=%" PRIu8 ", it should be larger than 0 " > "and less than or equal to %d", node->level,