From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: zhang.zhanghailiang@huawei.com,
Pan Nengyuan <pannengyuan@huawei.com>,
qemu-devel@nongnu.org, euler.robot@huawei.com
Subject: Re: [PATCH 1/2] migration/rdma: fix potential nullptr access in rdma_start_incoming_migration
Date: Fri, 29 May 2020 18:21:20 +0100 [thread overview]
Message-ID: <20200529172120.GP2856@work-vm> (raw)
In-Reply-To: <878si2hnht.fsf@secure.mitica>
* Juan Quintela (quintela@redhat.com) wrote:
> Pan Nengyuan <pannengyuan@huawei.com> wrote:
> > 'rdma' is NULL when taking the first error branch in rdma_start_incoming_migration.
> > And it will cause a null pointer access in label 'err'. Fix that.
> >
> > Fixes: 59c59c67ee6b0327ae932deb303caa47919aeb1e
> > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> good catch.
Thanks, Queued
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-05-29 17:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 10:07 [PATCH 0/2] migration/rdma: fix nullptr-def in rdma_start_incoming_migration Pan Nengyuan
2020-05-08 10:07 ` [PATCH 1/2] migration/rdma: fix potential nullptr access " Pan Nengyuan
2020-05-08 7:52 ` Juan Quintela
2020-05-11 9:34 ` Peter Maydell
2020-05-29 17:21 ` Dr. David Alan Gilbert [this message]
2020-05-08 10:07 ` [PATCH 2/2] migration/rdma: cleanup rdma context before g_free to avoid memleaks Pan Nengyuan
2020-05-08 7:54 ` Juan Quintela
2020-05-29 17:27 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529172120.GP2856@work-vm \
--to=dgilbert@redhat.com \
--cc=euler.robot@huawei.com \
--cc=pannengyuan@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).