From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] migration/vmstate: Remove unnecessary MemoryRegion forward declaration
Date: Mon, 1 Jun 2020 10:35:39 +0100 [thread overview]
Message-ID: <20200601093539.GD2743@work-vm> (raw)
In-Reply-To: <20200530165512.15225-1-f4bug@amsat.org>
* Philippe Mathieu-Daudé (f4bug@amsat.org) wrote:
> "migration/vmstate.h" only uses pointer to MemoryRegion, which
> is already forward declared in "qemu/typedefs.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> CI: https://travis-ci.org/github/philmd/qemu/builds/692879495
> ---
> include/migration/vmstate.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> index 30667631bc..eafa39f560 100644
> --- a/include/migration/vmstate.h
> +++ b/include/migration/vmstate.h
> @@ -1199,7 +1199,6 @@ static inline int vmstate_register(VMStateIf *obj, int instance_id,
> void vmstate_unregister(VMStateIf *obj, const VMStateDescription *vmsd,
> void *opaque);
>
> -struct MemoryRegion;
> void vmstate_register_ram(struct MemoryRegion *memory, DeviceState *dev);
> void vmstate_unregister_ram(struct MemoryRegion *memory, DeviceState *dev);
> void vmstate_register_ram_global(struct MemoryRegion *memory);
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
and queued.
> --
> 2.21.3
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2020-06-01 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 16:55 [PATCH] migration/vmstate: Remove unnecessary MemoryRegion forward declaration Philippe Mathieu-Daudé
2020-06-01 9:35 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601093539.GD2743@work-vm \
--to=dgilbert@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).