Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

[Jon Doron <arilou@gmail.com>]

On 01/06/2020, Alex Bennée wrote:
>
>Jon Doron <arilou@gmail.com> writes:
>
>> On 31/05/2020, Peter Maydell wrote:
>>>On Sun, 31 May 2020 at 17:42, Jon Doron <arilou@gmail.com> wrote:
>>>>
>>>> On 31/05/2020, Philippe Mathieu-Daudé wrote:
>>>> >On 3/30/20 6:41 PM, Peter Maydell wrote:
>>>> >> PS: do we have any documentation of this new command ?
>>>> >> ab4752ec8d9 has the implementation but no documentation...
>>>> >
>>>> >Jon, do you have documentation on the Qqemu.PhyMemMode packet?
>>>
>>>> Hi, there is no documentation for this mode, but in general the idea was
>>>> very simple.
>>>>
>>>> I want to have GDB the option to see the physical memory and examine it
>>>> and have this option toggled.
>>>>
>>>> This was useful to me when I was working on nested virtual machine and I
>>>> wanted to examine different states of the VMCS12 and EPTs.
>>>>
>>>> I used this in the following commands:
>>>> // Enable
>>>> maint packet Qqemu.PhyMemMode:1
>>>>
>>>> // Disable
>>>> maint packet Qqemu.PhyMemMode:0
>>>
>>>docs/system/gdb.rst would be the place to document QEMU-specific
>>>extensions to the gdb protocol (there's an "advanced debugging
>>>options" section where we document things like the single-step
>>>stuff you can also change via 'maint packet').
>>>
>>>thanks
>>>-- PMM
>>
>> Thanks, I'll know for next time, when I did all that work and
>> re-factored gdbstub, that doc did not exist.
>
>The documentation existed in our old texinfo docs, however they have
>been recently updated to rst and are now considerably easier to find and
>hack on now.
>
>> Perhaps Peter can just add the documentation to this commit?
>
>Please don't impose extra burden on our overworked maintainer when he's
>already given review feedback. Generally maintainers have more work to
>do than time to do it in so the easiest way to expedite patches with
>features you want added is to send well formed complete patches which
>can be easily merged. Otherwise patches tend to end up deep in a pile of
>"must get around to that when I can".
>
>-- 
>Alex Bennée

No problem, I'll revise a patch to the rst and send it.

Thanks,
-- Jon.