From: Lukas Straub <lukasstraub2@web.de>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Zhanghailiang <zhang.zhanghailiang@huawei.com>,
Jason Wang <jasowang@redhat.com>,
qemu-dev <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>,
Zhang Chen <chen.zhang@intel.com>,
Zhang Chen <zhangckid@gmail.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] block/quorum.c: Decrease child index when del_child
Date: Mon, 1 Jun 2020 20:12:00 +0200 [thread overview]
Message-ID: <20200601201200.10e2ea59@luklap> (raw)
In-Reply-To: <w515zcbm5p3.fsf@maestria.local.igalia.com>
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
On Mon, 01 Jun 2020 12:38:32 +0200
Alberto Garcia <berto@igalia.com> wrote:
> As I explained a few weeks ago this patch is not correct.
> quorum_del_child() allows you to remove any child from the Quorum
> device, so nothing guarantees that next_child_index-1 is free.
>
> https://lists.gnu.org/archive/html/qemu-block/2020-05/msg00634.html
>
> Berto
>
Hi,
Did you have a look at my series? There it's fixed properly:
https://lore.kernel.org/qemu-devel/9df6b3723ec30cb749ceaa555d82a29a6d79496d.1589199922.git.lukasstraub2@web.de/
Regards,
Lukas Straub
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-06-01 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 7:19 [PATCH] block/quorum.c: Decrease child index when del_child Zhang Chen
2020-06-01 10:38 ` Alberto Garcia
2020-06-01 18:12 ` Lukas Straub [this message]
2020-06-01 21:41 ` Alberto Garcia
2020-06-02 0:59 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601201200.10e2ea59@luklap \
--to=lukasstraub2@web.de \
--cc=berto@igalia.com \
--cc=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).