From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 078EEC433E0 for ; Wed, 3 Jun 2020 09:01:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4C3E205CB for ; Wed, 3 Jun 2020 09:01:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="COommNRN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4C3E205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgPHX-0000V6-2Z for qemu-devel@archiver.kernel.org; Wed, 03 Jun 2020 05:01:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgPGe-0008NC-3G for qemu-devel@nongnu.org; Wed, 03 Jun 2020 05:01:00 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:31305 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jgPGd-0001ye-8l for qemu-devel@nongnu.org; Wed, 03 Jun 2020 05:00:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591174858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DHj6tLyf9S7/6Sv8glItYl+EoHdX+AWQlvyGji12oYc=; b=COommNRNhZMdHQ3Rntg+rQo9SvpX1ylZ8INO5YoGwUsXKKzAFEjUSF7VDW7WEiYNiqWnnu 6/W02aNfet5sCiJQqfEElzpGO7ehiiAdY1DDU9uNHlpU2RMklAnYA97HG5dkLr0Qfh29a9 z6gNh0HWoK7C+HQ76ZH8AtGjyf7LplA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-O6RlNDktM1W2D5GVNn8tyg-1; Wed, 03 Jun 2020 05:00:54 -0400 X-MC-Unique: O6RlNDktM1W2D5GVNn8tyg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE441835B47; Wed, 3 Jun 2020 09:00:52 +0000 (UTC) Received: from linux.fritz.box (ovpn-112-187.ams2.redhat.com [10.36.112.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB14F78F16; Wed, 3 Jun 2020 09:00:50 +0000 (UTC) Date: Wed, 3 Jun 2020 11:00:49 +0200 From: Kevin Wolf To: John Snow Subject: Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module Message-ID: <20200603090049.GB5127@linux.fritz.box> References: <20200514055403.18902-1-jsnow@redhat.com> <20200514055403.18902-2-jsnow@redhat.com> <20200602100837.GA5940@linux.fritz.box> <864d1ab3-3f57-1d10-1f46-19cd7856d99a@redhat.com> MIME-Version: 1.0 In-Reply-To: <864d1ab3-3f57-1d10-1f46-19cd7856d99a@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=kwolf@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/03 01:04:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-block@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Max Reitz , Alex =?iso-8859-1?Q?Benn=E9e?= , Cleber Rosa , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 02.06.2020 um 18:44 hat John Snow geschrieben: > > > On 6/2/20 6:08 AM, Kevin Wolf wrote: > > Am 14.05.2020 um 07:53 hat John Snow geschrieben: > >> move python/qemu/*.py to python/qemu/lib/*.py. > >> > >> To create a namespace package, the 'qemu' directory itself shouldn't > >> have module files in it. Thus, these files will go under a 'lib' package > >> directory instead. > >> > >> Bolster the lib/__init__.py file a little bit, Make the top-level > >> classes and functions available directly inside the `qemu.lib` > >> namespace, to facilitate a convenient shorthand: > >> > >>> from qemu.lib import QEMUQtestMachine, QEMUMonitorProtocol > >> > >> Lastly, update all of the existing import directives. > >> > >> (Note: these scripts were not necessarily tested to see if they still > >> work. Some of these scripts are in obvious states of disrepair and it is > >> beyond the scope of this patch to attempt to fix them.) > >> > >> Signed-off-by: John Snow > >> --- > >> python/qemu/__init__.py | 11 ----- > > > > When trying to reproduce your mypy problem, I was wondering why mypy was > > complaining that it couldn't find qemu.lib. The reason is that removing > > __init__.py from qemu means it's not a valid module any more. If I > > recreate it locally, mypy stops complaining. > > > > So I think we need to leave this file here. > > > > Kevin > > > > Depends. You'll want --namespace-packages to parse a PEP420 namespace. > > (It's not a given we definitely want a PEP420 namespace, but that's what > I created here.) I'm just running 297, so if this is how mypy should be called now, the series needs to make a change to 297. Kevin