From: Gerd Hoffmann <kraxel@redhat.com>
To: P J P <ppandit@redhat.com>
Cc: Prasad J Pandit <pjp@fedoraproject.org>,
Yi Ren <c4tren@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Ren Ding <rding@gatech.edu>, Hanqing Zhao <hanqing@gatech.edu>
Subject: Re: [PATCH] ati-vga: increment mm_index in ati_mm_read/write
Date: Wed, 3 Jun 2020 15:44:04 +0200 [thread overview]
Message-ID: <20200603134404.xdb2koul7fatv4ez@sirius.home.kraxel.org> (raw)
In-Reply-To: <20200603124732.1137892-1-ppandit@redhat.com>
On Wed, Jun 03, 2020 at 06:17:32PM +0530, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> While accessing VGA registers via ati_mm_read/write routines,
> a guest may set 's->regs.mm_index' such that it leads to infinite
> recursion.
Lovely.
> Increment the mm_index value to avoid it.
Hmm, why modify mm_index? Shouldn't we just check it is non-zero
before calling ati_mm_read/ati_mm_write?
cheers,
Gerd
next prev parent reply other threads:[~2020-06-03 13:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 12:47 [PATCH] ati-vga: increment mm_index in ati_mm_read/write P J P
2020-06-03 13:44 ` Gerd Hoffmann [this message]
2020-06-03 13:56 ` BALATON Zoltan
2020-06-03 14:35 ` P J P
2020-06-03 15:32 ` Gerd Hoffmann
2020-06-03 15:38 ` BALATON Zoltan
2020-06-03 15:43 ` BALATON Zoltan
2020-06-03 19:08 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603134404.xdb2koul7fatv4ez@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=c4tren@gmail.com \
--cc=hanqing@gatech.edu \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rding@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).