From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Prasad J Pandit" <pjp@fedoraproject.org>,
"Yi Ren" <c4tren@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"P J P" <ppandit@redhat.com>, "Gerd Hoffmann" <kraxel@redhat.com>,
"Ren Ding" <rding@gatech.edu>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Hanqing Zhao" <hanqing@gatech.edu>
Subject: Re: [PATCH v2 2/2] pci: ensure configuration access is within bounds
Date: Thu, 4 Jun 2020 05:35:26 -0400 [thread overview]
Message-ID: <20200604053351-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAFEAcA-hApgPBn0o44sJW7=WGiLnL0PBhz+1i8MAcxwuxJ=Y=w@mail.gmail.com>
On Thu, Jun 04, 2020 at 10:10:07AM +0100, Peter Maydell wrote:
> On Wed, 3 Jun 2020 at 21:26, P J P <ppandit@redhat.com> wrote:
> >
> > From: Prasad J Pandit <pjp@fedoraproject.org>
> >
> > While reading PCI configuration bytes, a guest may send an
> > address towards the end of the configuration space. It may lead
> > to an OOB access issue. Assert that 'address + len' is within
> > PCI configuration space.
>
> What does the spec say should happen when the guest does this?
Spec says anything can happen *to the device*. Naturally there's
an expectation that while device might crash it stays
resettable and does not blow up.
> Does it depend on the pci controller implementation?
>
> thanks
> -- PMM
Shouldn't I think.
--
MST
next prev parent reply other threads:[~2020-06-04 9:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 20:22 [PATCH v2 0/2] Ensure PCI configuration access is within bounds P J P
2020-06-03 20:22 ` [PATCH v2 1/2] ait-vga: check address before reading configuration bytes P J P
2020-06-03 21:58 ` BALATON Zoltan
2020-06-04 8:43 ` Daniel P. Berrangé
2020-06-04 9:18 ` P J P
2020-06-04 9:40 ` Michael S. Tsirkin
2020-06-03 20:22 ` [PATCH v2 2/2] pci: ensure configuration access is within bounds P J P
2020-06-03 22:13 ` BALATON Zoltan
2020-06-04 5:14 ` Gerd Hoffmann
2020-06-04 9:44 ` Michael S. Tsirkin
2020-06-04 5:31 ` P J P
2020-06-04 6:07 ` Philippe Mathieu-Daudé
2020-06-04 9:41 ` Michael S. Tsirkin
2020-06-04 11:37 ` BALATON Zoltan
2020-06-04 11:40 ` Michael S. Tsirkin
2020-06-04 11:49 ` BALATON Zoltan
2020-06-04 11:58 ` Michael S. Tsirkin
2020-06-04 12:14 ` BALATON Zoltan
2020-06-04 14:11 ` Michael S. Tsirkin
2020-06-04 9:10 ` Peter Maydell
2020-06-04 9:35 ` Michael S. Tsirkin [this message]
2020-06-04 9:38 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604053351-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=berrange@redhat.com \
--cc=c4tren@gmail.com \
--cc=hanqing@gatech.edu \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rding@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).