qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dinechin@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH 0/2] build qxl as module
Date: Thu, 4 Jun 2020 09:48:20 +0100	[thread overview]
Message-ID: <20200604084820.GC3050580@redhat.com> (raw)
In-Reply-To: <20200604075943.7001-1-kraxel@redhat.com>

On Thu, Jun 04, 2020 at 09:59:41AM +0200, Gerd Hoffmann wrote:
>

There's no info here, or in the commit message about the
intended goal of this modularization ? If we're modularizing
devices, why only qxl and not other devices too ?

> 
> Gerd Hoffmann (2):
>   qdev: add support for device module loading
>   vga: build qxl as module
> 
>  Makefile.objs            |  1 +
>  Makefile.target          |  7 ++++++
>  include/hw/qdev-core.h   |  3 +++
>  include/qemu/module.h    |  1 +
>  hw/core/qdev.c           | 49 ++++++++++++++++++++++++++++++++++++++++
>  qdev-monitor.c           |  5 ++++
>  hw/Makefile.objs         |  1 +
>  hw/display/Makefile.objs |  4 +++-
>  8 files changed, 70 insertions(+), 1 deletion(-)
> 
> -- 
> 2.18.4
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  parent reply	other threads:[~2020-06-04  8:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04  7:59 [PATCH 0/2] build qxl as module Gerd Hoffmann
2020-06-04  7:59 ` [PATCH 1/2] qdev: add support for device module loading Gerd Hoffmann
2020-06-04  7:59 ` [PATCH 2/2] vga: build qxl as module Gerd Hoffmann
2020-06-04  8:23 ` [PATCH 0/2] " no-reply
2020-06-04  8:30 ` no-reply
2020-06-04  8:48 ` Daniel P. Berrangé [this message]
2020-06-04  9:18   ` Gerd Hoffmann
2020-06-04 11:10     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200604084820.GC3050580@redhat.com \
    --to=berrange@redhat.com \
    --cc=dinechin@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).