From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DE65C433E1 for ; Thu, 4 Jun 2020 14:51:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDA8D20663 for ; Thu, 4 Jun 2020 14:51:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fHwSw/PG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDA8D20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgrDg-0003Jy-5o for qemu-devel@archiver.kernel.org; Thu, 04 Jun 2020 10:51:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgrCZ-0001hz-5J for qemu-devel@nongnu.org; Thu, 04 Jun 2020 10:50:39 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:37005 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jgrCX-0003ou-OQ for qemu-devel@nongnu.org; Thu, 04 Jun 2020 10:50:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591282235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FP3T2XMROyAkQ/sm++H4HgCNTMSl71bWf6z8iDw0SMs=; b=fHwSw/PGyux/xM42D9m3PEHhlebYlFDelRP2tTCpodC9oua0DQs87cdZINiRZos9gB8/O0 e81JrxRcHAVR9aU/781F2r+eVjj1apXe/96VtHaoCsTUw2wgrW/JnYWCOhFO60QjrarSUG F+nr/JGGcaIvl4d3DQo/D8R/WOBt65g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-k-netvHhNGCvE2WWbaMKcg-1; Thu, 04 Jun 2020 10:50:30 -0400 X-MC-Unique: k-netvHhNGCvE2WWbaMKcg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6CF3A64ADA; Thu, 4 Jun 2020 14:50:28 +0000 (UTC) Received: from linux.fritz.box (ovpn-112-65.ams2.redhat.com [10.36.112.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EDC6660BF4; Thu, 4 Jun 2020 14:50:24 +0000 (UTC) Date: Thu, 4 Jun 2020 16:50:23 +0200 From: Kevin Wolf To: John Snow Subject: Re: [PATCH v2 16/16] python/qemu: Add mypy type annotations Message-ID: <20200604145023.GI4512@linux.fritz.box> References: <20200602214528.12107-1-jsnow@redhat.com> <20200602214528.12107-17-jsnow@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200602214528.12107-17-jsnow@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/04 01:31:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , Cleber Rosa , philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 02.06.2020 um 23:45 hat John Snow geschrieben: > These should all be purely annotations with no changes in behavior at > all. You need to be in the python folder, but you should be able to > confirm that these annotations are correct (or at least self-consistent) > by running `mypy --strict qemu`. > > Signed-off-by: John Snow > diff --git a/python/qemu/qtest.py b/python/qemu/qtest.py > index ae4661d4d3e..df6300cd4f7 100644 > --- a/python/qemu/qtest.py > +++ b/python/qemu/qtest.py > @@ -24,6 +24,8 @@ > Optional, > Sequence, > TextIO, > + Tuple, > + Union, > ) > > from .machine import QEMUMachine > @@ -43,7 +45,8 @@ class QEMUQtestProtocol: > No conection is estabalished by __init__(), this is done > by the connect() or accept() methods. > """ > - def __init__(self, address, server=False): > + def __init__(self, address: Union[Tuple[str, str], str], > + server: bool = False): Shouldn't this be SocketAddrT now? Kevin