From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [PATCH] checkpatch: reversed logic with acpi test checks
Date: Thu, 4 Jun 2020 15:08:53 -0400 [thread overview]
Message-ID: <20200604150734-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <b03eaa8c-fb1d-523a-6e41-c1d4ceaafd53@redhat.com>
On Thu, Jun 04, 2020 at 08:45:15PM +0200, Paolo Bonzini wrote:
> On 02/06/20 07:36, Michael S. Tsirkin wrote:
> > Logic reversed: allowed list should just be ignored. Instead we
> > only take that into account :(
> >
> > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list")
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > scripts/checkpatch.pl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 0ba213e9f2..55aa45dc16 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -1267,7 +1267,7 @@ sub checkfilename {
> > # files and when changing tests.
> > if ($name =~ m#^tests/data/acpi/# and not $name =~ m#^\.sh$#) {
> > $$acpi_testexpected = $name;
> > - } elsif ($name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> > + } elsif (not $name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> > $$acpi_nontestexpected = $name;
> > }
> > if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) {
> >
>
> Queued with "!~" to achieve the logical not.
>
> Paolo
Hmm perl manual says "not" is the logical not. Weird.
What's !~? My perl is a bit rusty :)
next prev parent reply other threads:[~2020-06-04 19:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 5:36 [PATCH] checkpatch: reversed logic with acpi test checks Michael S. Tsirkin
2020-06-02 7:40 ` Philippe Mathieu-Daudé
2020-06-02 11:39 ` Auger Eric
2020-06-04 18:45 ` Paolo Bonzini
2020-06-04 19:08 ` Michael S. Tsirkin [this message]
2020-06-04 19:52 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604150734-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).