Re: [PATCH v3] migration/xbzrle: add encoding rate

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Wei Wang (wei.w.wang@intel.com) wrote:
> On 06/05/2020 12:57 AM, Richard Henderson wrote:
> > On 6/4/20 3:27 AM, Wei Wang wrote:
> > > On 06/04/2020 05:38 PM, Dr. David Alan Gilbert wrote:
> > > > Hmm OK; I'll admit to not liking NaN/Inf in output.
> > > > 
> > > > Dave
> > > > 
> > > OK. To deal with the reported issue, how about using FLT_MAX (as opposed to
> > > UINT64_MAX or inf):
> > > xbzrle_counters.encoding_rate = FLT_MAX;
> > So you'd rather see 340282346638528859811704183484516925440.00 printed?
> > 
> > It's arbitrary and not correct in any mathematical sense.
> > 
> > If you *really* insist on not printing Inf (which may have some diagnostic
> > value), then 0 is just as arbitrary, and at least smaller in the output.
> 
> 0 works fine (though it logically means the lowest encoding rate).
> I slightly prefer the biggest number or inf, which naturally means it's very
> encoding friendly.
> Let's see if Dave has any thought about the choices :)

0 is fine for me.

Dave

> Best,
> Wei
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK