From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v6 07/11] Makefile: Write MINIKCONF variables as one entry per line
Date: Fri, 5 Jun 2020 11:32:52 +0200 [thread overview]
Message-ID: <20200605093256.30351-8-philmd@redhat.com> (raw)
In-Reply-To: <20200605093256.30351-1-philmd@redhat.com>
Having one entry per line helps reviews/refactors. As we are
going to modify the MINIKCONF variables, split them now to
ease further review.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Makefile | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 6c9d718b2c..7666f81e8a 100644
--- a/Makefile
+++ b/Makefile
@@ -418,12 +418,15 @@ MINIKCONF_ARGS = \
CONFIG_LINUX=$(CONFIG_LINUX) \
CONFIG_PVRDMA=$(CONFIG_PVRDMA)
-MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig
-MINIKCONF_DEPS = $(MINIKCONF_INPUTS) $(wildcard $(SRC_PATH)/hw/*/Kconfig)
+MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host \
+ $(SRC_PATH)/hw/Kconfig
+MINIKCONF_DEPS = $(MINIKCONF_INPUTS) \
+ $(wildcard $(SRC_PATH)/hw/*/Kconfig)
MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py
$(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak
- $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) > $@.tmp, "GEN", "$@.tmp")
+ $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) \
+ > $@.tmp, "GEN", "$@.tmp")
$(call quiet-command, if test -f $@; then \
if cmp -s $@.old $@; then \
mv $@.tmp $@; \
--
2.21.3
next prev parent reply other threads:[~2020-06-05 9:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 9:32 [PATCH v6 00/11] accel: Allow targets to use Kconfig Philippe Mathieu-Daudé
2020-06-05 9:32 ` [PATCH v6 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-06-08 9:59 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 02/11] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-06-08 10:00 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 03/11] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
2020-06-08 9:27 ` Wang, Wenchao
2020-06-08 15:25 ` Philippe Mathieu-Daudé
2020-06-05 9:32 ` [PATCH v6 04/11] rules.mak: Add strequal() and startwith() rules Philippe Mathieu-Daudé
2020-06-05 9:32 ` [PATCH v6 05/11] rules.mak: Add base-arch() rule Philippe Mathieu-Daudé
2020-06-08 10:10 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 06/11] Makefile: Remove dangerous EOL trailing backslash Philippe Mathieu-Daudé
2020-06-08 10:10 ` Alex Bennée
2020-06-05 9:32 ` Philippe Mathieu-Daudé [this message]
2020-06-08 10:13 ` [PATCH v6 07/11] Makefile: Write MINIKCONF variables as one entry per line Alex Bennée
2020-06-05 9:32 ` [PATCH v6 08/11] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-06-08 10:13 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 09/11] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-06-08 10:15 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 10/11] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-06-08 11:09 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 11/11] accel/tcg: Add stub for probe_access() Philippe Mathieu-Daudé
2020-06-08 11:08 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605093256.30351-8-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).