From: Stefan Hajnoczi <stefanha@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Julia Suvorova <jusual@redhat.com>, Max Reitz <mreitz@redhat.com>,
Alexander Bulekov <alxndr@bu.edu>, Bandan Das <bsd@redhat.com>,
qemu-arm@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Keith Busch <kbusch@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Aarushi Mehta <mehta.aaru20@gmail.com>,
Richard Henderson <rth@twiddle.net>
Subject: [PULL 01/11] io_uring: retry io_uring_submit() if it fails with errno=EINTR
Date: Fri, 5 Jun 2020 10:47:40 +0100 [thread overview]
Message-ID: <20200605094750.149957-2-stefanha@redhat.com> (raw)
In-Reply-To: <20200605094750.149957-1-stefanha@redhat.com>
From: Stefano Garzarella <sgarzare@redhat.com>
As recently documented [1], io_uring_enter(2) syscall can return an
error (errno=EINTR) if the operation was interrupted by a delivery
of a signal before it could complete.
This should happen when IORING_ENTER_GETEVENTS flag is used, for
example during io_uring_submit_and_wait() or during io_uring_submit()
when IORING_SETUP_IOPOLL is enabled.
We shouldn't have this problem for now, but it's better to prevent it.
[1] https://github.com/axboe/liburing/commit/344355ec6619de8f4e64584c9736530b5346e4f4
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Message-id: 20200519133041.112138-1-sgarzare@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/io_uring.c b/block/io_uring.c
index a3142ca989..9765681f7c 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -231,7 +231,7 @@ static int ioq_submit(LuringState *s)
trace_luring_io_uring_submit(s, ret);
/* Prevent infinite loop if submission is refused */
if (ret <= 0) {
- if (ret == -EAGAIN) {
+ if (ret == -EAGAIN || ret == -EINTR) {
continue;
}
break;
--
2.25.4
next prev parent reply other threads:[~2020-06-05 9:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 9:47 [PULL 00/11] Block patches Stefan Hajnoczi
2020-06-05 9:47 ` Stefan Hajnoczi [this message]
2020-06-05 9:47 ` [PULL 02/11] io_uring: use io_uring_cq_ready() to check for ready cqes Stefan Hajnoczi
2020-06-05 9:47 ` [PULL 03/11] fuzz: add datadir for oss-fuzz compatability Stefan Hajnoczi
2020-06-05 9:47 ` [PULL 04/11] fuzz: fix typo in i440fx-qtest-reboot arguments Stefan Hajnoczi
2020-06-05 9:47 ` [PULL 05/11] fuzz: add mangled object name to linker script Stefan Hajnoczi
2020-06-05 9:47 ` [PULL 06/11] fuzz: run the main-loop in fork-server process Stefan Hajnoczi
2020-06-05 9:47 ` [PULL 07/11] memory: Rename memory_region_do_writeback -> memory_region_writeback Stefan Hajnoczi
2020-06-05 9:47 ` [PULL 08/11] memory: Extract memory_region_msync() from memory_region_writeback() Stefan Hajnoczi
2020-06-05 9:47 ` [PULL 09/11] hw/block: Let the NVMe emulated device be target-agnostic Stefan Hajnoczi
2020-06-05 9:47 ` [PULL 10/11] exec: Rename qemu_ram_writeback() as qemu_ram_msync() Stefan Hajnoczi
2020-06-05 9:47 ` [PULL 11/11] block: Factor out bdrv_run_co() Stefan Hajnoczi
2020-06-05 12:52 ` [PULL 00/11] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605094750.149957-2-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=fam@euphon.net \
--cc=jusual@redhat.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=mehta.aaru20@gmail.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sgarzare@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).