From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>, Laurent Vivier <laurent@vivier.eu>
Subject: [PULL 01/19] linux-user, alpha: fix oldumount syscall
Date: Fri, 5 Jun 2020 13:46:42 +0200 [thread overview]
Message-ID: <20200605114700.1052050-2-laurent@vivier.eu> (raw)
In-Reply-To: <20200605114700.1052050-1-laurent@vivier.eu>
When we try to bootstrap debian/lenny for alpha, it fails because
it cannot umount /.root directory:
...
Setting up initscripts (2.86.ds1-61) ...
umount: /.root: Function not implemented
dpkg: error processing initscripts (--configure):
subprocess post-installation script returned error exit status 1
dpkg: sysvinit: dependency problems, but configuring anyway as you request:
sysvinit depends on initscripts; however:
Package initscripts is not configured yet.
This is because, when we switched from syscall_nr.h to syscall.tbl,
the syscall #321 has been renamed from umount to oldumount and
syscall.c has not been updated to manage the new name.
oldumount has been introduced in linux 2.1.116pre1 by:
7d32756b2 ("Import 2.1.116pre1")
...
* We now support a flag for forced unmount like the other 'big iron'
* unixes. Our API is identical to OSF/1 to avoid making a mess of AMD
...
Fixes: 6116aea994 ("linux-user, alpha: add syscall table generation support")
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200502194642.32823-1-laurent@vivier.eu>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/syscall.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 05f03919ff07..e89b815ce983 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8028,8 +8028,13 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
}
}
return ret;
-#ifdef TARGET_NR_umount
+#if defined(TARGET_NR_umount) || defined(TARGET_NR_oldumount)
+#if defined(TARGET_NR_umount)
case TARGET_NR_umount:
+#endif
+#if defined(TARGET_NR_oldumount)
+ case TARGET_NR_oldumount:
+#endif
if (!(p = lock_user_string(arg1)))
return -TARGET_EFAULT;
ret = get_errno(umount(p));
--
2.26.2
next prev parent reply other threads:[~2020-06-05 11:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 11:46 [PULL 00/19] Linux user for 5.1 patches Laurent Vivier
2020-06-05 11:46 ` Laurent Vivier [this message]
2020-06-05 11:46 ` [PULL 02/19] linux-user: return target error codes for socket() and prctl() Laurent Vivier
2020-06-05 11:46 ` [PULL 03/19] linux-user: Add support for /proc/cpuinfo on hppa platform Laurent Vivier
2020-06-05 11:46 ` [PULL 04/19] linux-user/strace.list: fix epoll_create{, 1} -strace output Laurent Vivier
2020-06-05 11:46 ` [PULL 05/19] linux-user/mmap.c: fix integer underflow in target_mremap Laurent Vivier
2020-06-05 11:46 ` [PULL 06/19] linux-user: implement OFD locks Laurent Vivier
2020-06-05 11:46 ` [PULL 07/19] Makefile: Only build virtiofsd if system-mode is enabled Laurent Vivier
2020-06-05 11:46 ` [PULL 08/19] configure: Avoid building TCG when not needed Laurent Vivier
2020-06-05 11:46 ` [PULL 09/19] tests/Makefile: Only display TCG-related tests when TCG is available Laurent Vivier
2020-06-05 11:46 ` [PULL 10/19] tests/Makefile: Restrict some softmmu-only tests Laurent Vivier
2020-06-05 11:46 ` [PULL 11/19] util/Makefile: Reduce the user-mode object list Laurent Vivier
2020-06-05 11:46 ` [PULL 12/19] stubs/Makefile: " Laurent Vivier
2020-06-05 11:46 ` [PULL 13/19] target/riscv/cpu: Restrict CPU migration to system-mode Laurent Vivier
2020-06-05 11:46 ` [PULL 14/19] exec: Assert CPU migration is not used on user-only build Laurent Vivier
2020-06-05 11:46 ` [PULL 15/19] arch_init: Remove unused 'qapi-commands-misc.h' include Laurent Vivier
2020-06-05 11:46 ` [PULL 16/19] target/i386: Restrict CpuClass::get_crash_info() to system-mode Laurent Vivier
2020-06-05 11:46 ` [PULL 17/19] target/s390x: " Laurent Vivier
2020-06-05 11:46 ` [PULL 18/19] hw/core: " Laurent Vivier
2020-06-05 11:47 ` [PULL 19/19] stubs: Restrict ui/win32-kbd-hook " Laurent Vivier
2020-06-05 16:45 ` [PULL 00/19] Linux user for 5.1 patches Peter Maydell
2020-06-05 19:20 ` Laurent Vivier
2020-06-05 20:32 ` Peter Maydell
2020-06-05 21:48 ` Richard Henderson
2020-06-08 5:05 ` Thomas Huth
-- strict thread matches above, loose matches on Subject: below --
2020-06-05 11:41 Laurent Vivier
2020-06-05 11:41 ` [PULL 01/19] linux-user, alpha: fix oldumount syscall Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605114700.1052050-2-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).