[PATCH] MAINTAINERS: Add an entry to review Avocado based acceptance tests

[PATCH] MAINTAINERS: Add an entry to review Avocado based acceptance tests

[Philippe Mathieu-Daudé]

Add an entry for to allow reviewers to be notified when acceptance /
integration tests are added or modified.
The designated reviewers are not maintainers, subsystem maintainers
are expected to merge their tests.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3e7d9cb0a5..c2ae2bf390 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2923,6 +2923,14 @@ S: Maintained
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
 
+Acceptance (Integration) Testing with the Avocado framework
+W: https://trello.com/b/6Qi1pxVn/avocado-qemu
+R: Cleber Rosa <crosa@redhat.com>
+R: Philippe Mathieu-Daudé <philmd@redhat.com>
+R: Wainer dos Santos Moschetta <wainersm@redhat.com>
+S: Odd Fixes
+F: tests/acceptance/
+
 Documentation
 -------------
 Build system architecture
-- 
2.21.3

Re: [PATCH] MAINTAINERS: Add an entry to review Avocado based acceptance tests

[Philippe Mathieu-Daudé]

On 6/5/20 6:56 PM, Philippe Mathieu-Daudé wrote:
> Add an entry for to allow reviewers to be notified when acceptance /
> integration tests are added or modified.
> The designated reviewers are not maintainers, subsystem maintainers
> are expected to merge their tests.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3e7d9cb0a5..c2ae2bf390 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2923,6 +2923,14 @@ S: Maintained
>  F: tests/tcg/Makefile
>  F: tests/tcg/Makefile.include
>  
> +Acceptance (Integration) Testing with the Avocado framework
> +W: https://trello.com/b/6Qi1pxVn/avocado-qemu
> +R: Cleber Rosa <crosa@redhat.com>
> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
> +R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> +S: Odd Fixes
> +F: tests/acceptance/

Ping...? Please Nack if you don't want to be included.

> +
>  Documentation
>  -------------
>  Build system architecture
> 

Re: [PATCH] MAINTAINERS: Add an entry to review Avocado based acceptance tests

[Eduardo Habkost]

On Fri, Jun 05, 2020 at 06:56:56PM +0200, Philippe Mathieu-Daudé wrote:
> Add an entry for to allow reviewers to be notified when acceptance /
> integration tests are added or modified.
> The designated reviewers are not maintainers, subsystem maintainers
> are expected to merge their tests.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thank you very much for volunteering!

Acked-by: Eduardo Habkost <ehabkost@redhat.com>

> ---
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3e7d9cb0a5..c2ae2bf390 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2923,6 +2923,14 @@ S: Maintained
>  F: tests/tcg/Makefile
>  F: tests/tcg/Makefile.include
>  
> +Acceptance (Integration) Testing with the Avocado framework
> +W: https://trello.com/b/6Qi1pxVn/avocado-qemu
> +R: Cleber Rosa <crosa@redhat.com>
> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
> +R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> +S: Odd Fixes
> +F: tests/acceptance/
> +
>  Documentation
>  -------------
>  Build system architecture
> -- 
> 2.21.3
> 

-- 
Eduardo

Re: [PATCH] MAINTAINERS: Add an entry to review Avocado based acceptance tests

[Cleber Rosa]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

On Fri, Jun 05, 2020 at 06:56:56PM +0200, Philippe Mathieu-Daudé wrote:
> Add an entry for to allow reviewers to be notified when acceptance /
> integration tests are added or modified.
> The designated reviewers are not maintainers, subsystem maintainers
> are expected to merge their tests.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---

Thanks for this!

Acked-by: Cleber Rosa <crosa@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] MAINTAINERS: Add an entry to review Avocado based acceptance tests

[Philippe Mathieu-Daudé]

On 6/5/20 6:56 PM, Philippe Mathieu-Daudé wrote:
> Add an entry for to allow reviewers to be notified when acceptance /
> integration tests are added or modified.
> The designated reviewers are not maintainers, subsystem maintainers
> are expected to merge their tests.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3e7d9cb0a5..c2ae2bf390 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2923,6 +2923,14 @@ S: Maintained
>  F: tests/tcg/Makefile
>  F: tests/tcg/Makefile.include
>  
> +Acceptance (Integration) Testing with the Avocado framework
> +W: https://trello.com/b/6Qi1pxVn/avocado-qemu
> +R: Cleber Rosa <crosa@redhat.com>
> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
> +R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> +S: Odd Fixes
> +F: tests/acceptance/
> +
>  Documentation
>  -------------
>  Build system architecture
> 

Eh I already sent a similar patch... [1].

Considering Wainer reply in [2], patch applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next

[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg675105.html
[2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg675698.html

Re: [PATCH] MAINTAINERS: Add an entry to review Avocado based acceptance tests

[Alex Bennée]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Add an entry for to allow reviewers to be notified when acceptance /
> integration tests are added or modified.
> The designated reviewers are not maintainers, subsystem maintainers
> are expected to merge their tests.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3e7d9cb0a5..c2ae2bf390 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2923,6 +2923,14 @@ S: Maintained
>  F: tests/tcg/Makefile
>  F: tests/tcg/Makefile.include
>  
> +Acceptance (Integration) Testing with the Avocado framework
> +W: https://trello.com/b/6Qi1pxVn/avocado-qemu
> +R: Cleber Rosa <crosa@redhat.com>
> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
> +R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> +S: Odd Fixes
> +F: tests/acceptance/
> +
>  Documentation
>  -------------
>  Build system architecture


-- 
Alex Bennée

Re: [PATCH] MAINTAINERS: Add an entry to review Avocado based acceptance tests

[Philippe Mathieu-Daudé]

On 7/24/20 10:45 AM, Alex Bennée wrote:
> 
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> 
>> Add an entry for to allow reviewers to be notified when acceptance /
>> integration tests are added or modified.
>> The designated reviewers are not maintainers, subsystem maintainers
>> are expected to merge their tests.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Thanks, but the v2 has already been merged (commit 6634f1c43d).
https://www.mail-archive.com/qemu-devel@nongnu.org/msg675105.html

> 
>> ---
>>  MAINTAINERS | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 3e7d9cb0a5..c2ae2bf390 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2923,6 +2923,14 @@ S: Maintained
>>  F: tests/tcg/Makefile
>>  F: tests/tcg/Makefile.include
>>  
>> +Acceptance (Integration) Testing with the Avocado framework
>> +W: https://trello.com/b/6Qi1pxVn/avocado-qemu
>> +R: Cleber Rosa <crosa@redhat.com>
>> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
>> +R: Wainer dos Santos Moschetta <wainersm@redhat.com>
>> +S: Odd Fixes
>> +F: tests/acceptance/
>> +
>>  Documentation
>>  -------------
>>  Build system architecture
> 
>