From: Igor Mammedov <imammedo@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Salil Mehta <salil.mehta@huawei.com>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mst@redhat.com" <mst@redhat.com>
Subject: Re: [Question] Regarding PMU initialization within the QEMU for ARM VCPUs
Date: Fri, 5 Jun 2020 17:31:16 +0200 [thread overview]
Message-ID: <20200605173116.55419a1e@redhat.com> (raw)
In-Reply-To: <20200603093745.dwfb55ny34az7rez@kamzik.brq.redhat.com>
On Wed, 3 Jun 2020 11:37:45 +0200
Andrew Jones <drjones@redhat.com> wrote:
> On Mon, Jun 01, 2020 at 03:04:33PM +0000, Salil Mehta wrote:
> > Hello,
> > I could see below within function fdt_add_pmu_nodes() part of
> > hw/arm/virt.c during virt machine initialization time:
...
>
> > Q4. This function fdt_* looks to be wrongly named. The info
> > being initialized here shall be used even when ACPI is
> > being used. Initialization part and FDT info looked
> > mixed up here if I am right?
>
> Agreed. The function has the wrong name. mach-virt has many functions that
> mix the initialization and fdt building together, but those functions are
> named something like create_foo(). Patches welcome.
that was where I gave up on cpu hotplug arm/virt the last time.
Ideally we should split out from create_foo() all firmware generation code
(fdt) and move it to virt_machine_done time + make sure that it could be
regenerated at reset time so guest would get updated FDT on reset.
>
> Thanks,
> drew
next prev parent reply other threads:[~2020-06-05 15:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 15:04 [Question] Regarding PMU initialization within the QEMU for ARM VCPUs Salil Mehta
2020-06-03 9:37 ` Andrew Jones
2020-06-03 9:59 ` Auger Eric
2020-06-03 10:21 ` Andrew Jones
2020-06-03 11:39 ` Auger Eric
2020-06-05 15:24 ` Igor Mammedov
2020-06-03 11:50 ` Salil Mehta
2020-06-03 11:45 ` Salil Mehta
2020-06-03 12:16 ` Andrew Jones
2020-06-03 13:48 ` Salil Mehta
2020-06-03 14:36 ` Andrew Jones
2020-06-03 14:53 ` Salil Mehta
2020-06-05 15:31 ` Igor Mammedov [this message]
2020-06-05 16:38 ` Salil Mehta
2020-06-08 12:00 ` Igor Mammedov
2020-06-08 13:49 ` Salil Mehta
-- strict thread matches above, loose matches on Subject: below --
2020-06-03 8:38 Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605173116.55419a1e@redhat.com \
--to=imammedo@redhat.com \
--cc=drjones@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=salil.mehta@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).