From: Zhang Chen <chen.zhang@intel.com >
To: "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
qemu-dev <qemu-devel@nongnu.org>
Cc: Zhang Chen <chen.zhang@intel.com>,
Zhanghailiang <zhang.zhanghailiang@huawei.com>,
Zhang Chen <zhangckid@gmail.com>
Subject: [PATCH V3 3/3] migration/migration.c: Remove MIGRATION_STATUS_ACTIVE in migration_iteration_finish
Date: Mon, 8 Jun 2020 03:46:11 +0800 [thread overview]
Message-ID: <20200607194611.24763-4-chen.zhang@intel.com> (raw)
In-Reply-To: <20200607194611.24763-1-chen.zhang@intel.com>
From: Zhang Chen <chen.zhang@intel.com>
MIGRATION_STATUS_ACTIVE is invalid here, handle it by default case.
Suggested-by: Lukas Straub <lukasstraub2@web.de>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
migration/migration.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 9059238e3d..9958b15202 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3319,11 +3319,6 @@ static void migration_iteration_finish(MigrationState *s)
*/
s->vm_was_running = true;
/* Fallthrough */
- case MIGRATION_STATUS_ACTIVE:
- /*
- * We should really assert here, but since it's during
- * migration, let's try to reduce the usage of assertions.
- */
case MIGRATION_STATUS_FAILED:
case MIGRATION_STATUS_CANCELLED:
case MIGRATION_STATUS_CANCELLING:
--
2.17.1
next prev parent reply other threads:[~2020-06-07 20:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 19:46 [PATCH V3 0/3] migration/colo: Optimize COLO framework code Zhang Chen
2020-06-07 19:46 ` [PATCH V3 1/3] migration/colo: Optimize COLO boot code path Zhang Chen
2020-06-08 7:24 ` Lukas Straub
2020-06-07 19:46 ` [PATCH V3 2/3] migration/colo: Update checkpoint time lately Zhang Chen
2020-06-07 19:46 ` Zhang Chen [this message]
2020-06-08 7:25 ` [PATCH V3 3/3] migration/migration.c: Remove MIGRATION_STATUS_ACTIVE in migration_iteration_finish Lukas Straub
2020-06-10 6:00 ` [PATCH V3 0/3] migration/colo: Optimize COLO framework code Zhang, Chen
2020-06-17 12:25 ` Dr. David Alan Gilbert
2020-06-22 6:52 ` Zhang, Chen
2020-07-08 6:39 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200607194611.24763-4-chen.zhang@intel.com \
--to=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).