From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "David Hildenbrand" <david@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v8 10/10] accel/tcg: Add stub for probe_access()
Date: Mon, 8 Jun 2020 18:38:23 +0200 [thread overview]
Message-ID: <20200608163823.8890-11-philmd@redhat.com> (raw)
In-Reply-To: <20200608163823.8890-1-philmd@redhat.com>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
The TCG helpers where added in b92e5a22ec3 in softmmu_template.h.
probe_write() was added in there in 3b4afc9e75a to be moved out
to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored
as probe_access() in c25c283df0f.
Since it is a TCG specific helper, add a stub to avoid failures
when building without TCG, such:
target/arm/helper.o: In function `probe_read':
include/exec/exec-all.h:362: undefined reference to `probe_access'
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
accel/stubs/tcg-stub.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
index 677191a69c..e4bbf997aa 100644
--- a/accel/stubs/tcg-stub.c
+++ b/accel/stubs/tcg-stub.c
@@ -22,3 +22,10 @@ void tb_flush(CPUState *cpu)
void tlb_set_dirty(CPUState *cpu, target_ulong vaddr)
{
}
+
+void *probe_access(CPUArchState *env, target_ulong addr, int size,
+ MMUAccessType access_type, int mmu_idx, uintptr_t retaddr)
+{
+ /* Handled by hardware accelerator. */
+ g_assert_not_reached();
+}
--
2.21.3
next prev parent reply other threads:[~2020-06-08 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 16:38 [PATCH v8 00/10] accel: Allow targets to use Kconfig Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 01/10] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 02/10] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 03/10] MAINTAINERS: Cover the HAX accelerator stub Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 04/10] configure: Generate rule to calculate the base architecture of a target Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 05/10] Makefile: Remove dangerous EOL trailing backslash Philippe Mathieu-Daudé
2020-06-08 16:39 ` Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 06/10] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 07/10] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 08/10] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 09/10] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-06-08 16:38 ` Philippe Mathieu-Daudé [this message]
2020-06-15 7:31 ` [PATCH v8 00/10] accel: Allow targets to use Kconfig Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608163823.8890-11-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=david@redhat.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).