From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v8 05/10] Makefile: Remove dangerous EOL trailing backslash
Date: Mon, 8 Jun 2020 18:38:18 +0200 [thread overview]
Message-ID: <20200608163823.8890-6-philmd@redhat.com> (raw)
In-Reply-To: <20200608163823.8890-1-philmd@redhat.com>
One might get caught trying to understand unexpected Makefile
behavior. Trailing backslash can help to split very long lines,
but are rather dangerous when nothing follow. Preserve other
developers debugging time by removing this one.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index d1af126ea1..52956b16fd 100644
--- a/Makefile
+++ b/Makefile
@@ -420,7 +420,7 @@ MINIKCONF_ARGS = \
MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig
MINIKCONF_DEPS = $(MINIKCONF_INPUTS) $(wildcard $(SRC_PATH)/hw/*/Kconfig)
-MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py \
+MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py
$(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak
$(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) > $@.tmp, "GEN", "$@.tmp")
--
2.21.3
next prev parent reply other threads:[~2020-06-08 16:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 16:38 [PATCH v8 00/10] accel: Allow targets to use Kconfig Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 01/10] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 02/10] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 03/10] MAINTAINERS: Cover the HAX accelerator stub Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 04/10] configure: Generate rule to calculate the base architecture of a target Philippe Mathieu-Daudé
2020-06-08 16:38 ` Philippe Mathieu-Daudé [this message]
2020-06-08 16:39 ` [PATCH v8 05/10] Makefile: Remove dangerous EOL trailing backslash Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 06/10] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 07/10] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 08/10] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 09/10] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-06-08 16:38 ` [PATCH v8 10/10] accel/tcg: Add stub for probe_access() Philippe Mathieu-Daudé
2020-06-15 7:31 ` [PATCH v8 00/10] accel: Allow targets to use Kconfig Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608163823.8890-6-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).