qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: xuwei@redhat.com, vsementsov@virtuozzo.com,
	qemu-stable@nongnu.org, qemu-block@nongnu.org,
	ppandit@redhat.com
Subject: [PATCH 0/2] Fix NBD CVE-2020-10761
Date: Mon,  8 Jun 2020 13:26:36 -0500	[thread overview]
Message-ID: <20200608182638.3256473-1-eblake@redhat.com> (raw)

In qemu 4.2, I accidentally introduced the ability for an NBD client
obeying the specification to kill qemu as NBD server with an assertion
failure when the client requests an unusually long export name, as a
regression from the intended graceful server error message back to the
client.  Given that the DoS security hole can be mitigated by
requiring TLS (and a client with TLS credentials is less likely to
play such games), the plan is to make the issue public today and send
a pull request through my NBD tree on Tuesday.

We may still want to revisit whether the block layer caps display
names to 4095 bytes, or whether it should track a malloc'd name even
when that name exceeds 4k.

Eric Blake (2):
  nbd/server: Avoid long error message assertions CVE-2020-10761
  block: Call attention to truncation of long NBD exports

 block.c                    |  7 +++++--
 block/nbd.c                | 21 +++++++++++++--------
 nbd/server.c               | 28 +++++++++++++++++++++++++---
 tests/qemu-iotests/143     |  4 ++++
 tests/qemu-iotests/143.out |  2 ++
 5 files changed, 49 insertions(+), 13 deletions(-)

-- 
2.27.0



             reply	other threads:[~2020-06-08 18:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08 18:26 Eric Blake [this message]
2020-06-08 18:26 ` [PATCH 1/2] nbd/server: Avoid long error message assertions CVE-2020-10761 Eric Blake
2020-06-09 18:41   ` Eric Blake
2020-06-10  8:57   ` Vladimir Sementsov-Ogievskiy
2020-06-10 13:39     ` Eric Blake
2020-06-10 13:52       ` Vladimir Sementsov-Ogievskiy
2020-06-08 18:26 ` [PATCH 2/2] block: Call attention to truncation of long NBD exports Eric Blake
2020-06-10  9:24   ` Vladimir Sementsov-Ogievskiy
2020-06-10 16:29     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200608182638.3256473-1-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    --cc=xuwei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).