qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, ehabkost@redhat.com,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Fabien Chouteau" <chouteau@adacore.com>,
	"KONRAD Frederic" <frederic.konrad@adacore.com>,
	pbonzini@redhat.com, "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>
Subject: [PATCH v3 21/24] sparc/leon3: Fix to put grlib,* devices on sysbus
Date: Tue,  9 Jun 2020 14:23:36 +0200	[thread overview]
Message-ID: <20200609122339.937862-22-armbru@redhat.com> (raw)
In-Reply-To: <20200609122339.937862-1-armbru@redhat.com>

leon3_generic_hw_init() creates a "grlib,ahbpnp" and a "grlib,apbpnp"
sysbus device in a way that leaves them unplugged.

Create them the common way that puts them into the main system bus.
Affects machine leon3_generic.  Visible in "info qtree":

     bus: main-system-bus
       type System
    +  dev: grlib,ahbpnp, id ""
    +    mmio 00000000fffff000/0000000000001000
    +  dev: grlib,apbpnp, id ""
    +    mmio 00000000800ff000/0000000000001000
       dev: grlib,irqmp, id ""

Cc: Fabien Chouteau <chouteau@adacore.com>
Cc: KONRAD Frederic <frederic.konrad@adacore.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Artyom Tarasenko <atar4qemu@gmail.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/sparc/leon3.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
index 8f024dab7b..3facb8c2ae 100644
--- a/hw/sparc/leon3.c
+++ b/hw/sparc/leon3.c
@@ -213,14 +213,14 @@ static void leon3_generic_hw_init(MachineState *machine)
     reset_info->sp    = LEON3_RAM_OFFSET + ram_size;
     qemu_register_reset(main_cpu_reset, reset_info);
 
-    ahb_pnp = GRLIB_AHB_PNP(object_new(TYPE_GRLIB_AHB_PNP));
+    ahb_pnp = GRLIB_AHB_PNP(qdev_create(NULL, TYPE_GRLIB_AHB_PNP));
     object_property_set_bool(OBJECT(ahb_pnp), true, "realized", &error_fatal);
     sysbus_mmio_map(SYS_BUS_DEVICE(ahb_pnp), 0, LEON3_AHB_PNP_OFFSET);
     grlib_ahb_pnp_add_entry(ahb_pnp, 0, 0, GRLIB_VENDOR_GAISLER,
                             GRLIB_LEON3_DEV, GRLIB_AHB_MASTER,
                             GRLIB_CPU_AREA);
 
-    apb_pnp = GRLIB_APB_PNP(object_new(TYPE_GRLIB_APB_PNP));
+    apb_pnp = GRLIB_APB_PNP(qdev_create(NULL, TYPE_GRLIB_APB_PNP));
     object_property_set_bool(OBJECT(apb_pnp), true, "realized", &error_fatal);
     sysbus_mmio_map(SYS_BUS_DEVICE(apb_pnp), 0, LEON3_APB_PNP_OFFSET);
     grlib_ahb_pnp_add_entry(ahb_pnp, LEON3_APB_PNP_OFFSET, 0xFFF,
-- 
2.26.2



  parent reply	other threads:[~2020-06-09 12:33 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 12:23 [PATCH v3 00/24] Fixes around device realization Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 01/24] arm/stm32f405: Fix realization of "stm32f2xx-adc" devices Markus Armbruster
2020-06-09 23:14   ` Alistair Francis
2020-06-09 12:23 ` [PATCH v3 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge" Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 03/24] sd/pxa2xx_mmci: Fix to realize "pxa2xx-mmci" device Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 04/24] arm/aspeed: Compute the number of CPUs from the SoC definition Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 05/24] arm/aspeed: Rework NIC attachment Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 06/24] armv7m: Delete unused "ARM,bitband-memory" devices Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 07/24] auxbus: Fix aux-to-i2c-bridge to be a subtype of aux-slave Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices Markus Armbruster
2020-06-10 15:46   ` Laurent Vivier
2020-06-09 12:23 ` [PATCH v3 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices Markus Armbruster
2020-06-15  5:26   ` Markus Armbruster
2020-06-15  6:15     ` Philippe Mathieu-Daudé
2020-06-09 12:23 ` [PATCH v3 10/24] macio: Delete unused "macio-gpio" devices Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 11/24] pnv/phb4: Delete unused "pnv-phb4-pec-stack" devices Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 12/24] MAINTAINERS: Make section PowerNV cover pci-host/pnv* as well Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 13/24] ppc4xx: Drop redundant device realization Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 14/24] macio: Put "macio-nvram" device on the macio bus Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 15/24] macio: Fix macio-bus to be a subtype of System bus Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 16/24] ppc/pnv: Put "*-pnv-chip" and "pnv-xive" on the main system bus Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 17/24] pnv/psi: Correct the pnv-psi* devices not to be sysbus devices Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 18/24] display/sm501 display/ati: Fix to realize "i2c-ddc" Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 19/24] riscv: Fix to put "riscv.hart_array" devices on sysbus Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 20/24] riscv: Fix type of SiFive[EU]SocState, member parent_obj Markus Armbruster
2020-06-09 12:23 ` Markus Armbruster [this message]
2020-06-09 13:07   ` [PATCH v3 21/24] sparc/leon3: Fix to put grlib, * devices on sysbus Artyom Tarasenko
2020-06-09 12:23 ` [PATCH v3 22/24] qdev: Assert devices are plugged into a bus that can take them Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 23/24] sd: Hide the qdev-but-not-quite thing created by sd_init() Markus Armbruster
2020-06-09 12:23 ` [PATCH v3 24/24] qdev: Assert onboard devices all get realized properly Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609122339.937862-22-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=atar4qemu@gmail.com \
    --cc=berrange@redhat.com \
    --cc=chouteau@adacore.com \
    --cc=ehabkost@redhat.com \
    --cc=frederic.konrad@adacore.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).