From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1F19C433E0 for ; Tue, 9 Jun 2020 14:25:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D712206D5 for ; Tue, 9 Jun 2020 14:25:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iIlWYQAv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D712206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jifBo-0004Il-7H for qemu-devel@archiver.kernel.org; Tue, 09 Jun 2020 10:25:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jif1P-00084T-4S for qemu-devel@nongnu.org; Tue, 09 Jun 2020 10:14:35 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:41520 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jif1N-0007mU-R3 for qemu-devel@nongnu.org; Tue, 09 Jun 2020 10:14:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591712073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MNIwianPSFqpLQfbkgbNEyR/uMiklhPkVKWtckjw9VM=; b=iIlWYQAvGtumJK/J9m574ruEEAiyj0pP0Ksu8S3OB5yFW69CAPdVJnF84TpIf3hsqN9VnL 1w2KhXJEjeS0ndv/gIFxROC+keqJjy5p+zY1PxlaPCeY0inJEyQd9P9vVzZEh7sjIg99V8 0xLKERe+TSMbeBwAaJbp6a+BN+O7XHg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-CdcVkegIMtuNSoszFNbVnw-1; Tue, 09 Jun 2020 10:14:31 -0400 X-MC-Unique: CdcVkegIMtuNSoszFNbVnw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A7F4919200C2; Tue, 9 Jun 2020 14:14:29 +0000 (UTC) Received: from linux.fritz.box (ovpn-114-124.ams2.redhat.com [10.36.114.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 991F75D9E4; Tue, 9 Jun 2020 14:14:27 +0000 (UTC) Date: Tue, 9 Jun 2020 16:14:25 +0200 From: Kevin Wolf To: Klaus Jensen Subject: Re: [PATCH 0/1] hw/block/nvme: fix assert on invalid irq vector Message-ID: <20200609141425.GC11003@linux.fritz.box> References: <20200609094508.32412-1-its@irrelevant.dk> <20200609114633.yvwtt6swb47l27yd@apples.localdomain> MIME-Version: 1.0 In-Reply-To: <20200609114633.yvwtt6swb47l27yd@apples.localdomain> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 23:42:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Keith Busch , Javier Gonzalez , Maxim Levitsky , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 09.06.2020 um 13:46 hat Klaus Jensen geschrieben: > On Jun 9 13:17, Philippe Mathieu-Daudé wrote: > > On 6/9/20 11:45 AM, Klaus Jensen wrote: > > > From: Klaus Jensen > > > > > > I goofed up with commit c09794fe40e3 ("hw/block/nvme: allow use of any > > > valid msix vector"). > > > > Kevin, since your queue isn't merged, can you directly squash the fix? > > The commit (c09794fe40e3) can just be dropped without conflicts, but it > leaves a use of n->params.num_queues in nvme_create_cq() which commit > cde74bfd4b87 ("hw/block/nvme: add max_ioqpairs device parameter") must > fix. Hm, so it seems this isn't easy to squash in without conflicts (and I would have to rewrite the whole commit message), so I think it's better to just apply the series on top. One problem with the commit message is that it references commit IDs which aren't stable yet. Maybe it's best if I apply these patches, manually fix up the commit ID references and then immediately do a pull request so that they become stable. It would be good to have at least one review, though. Kevin