From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v3 18/39] isa: New isa_new(), isa_realize_and_unref() etc.
Date: Tue, 9 Jun 2020 18:39:11 +0200 [thread overview]
Message-ID: <20200609163932.1566209-19-armbru@redhat.com> (raw)
In-Reply-To: <20200609163932.1566209-1-armbru@redhat.com>
I'm converting from qdev_create()/qdev_init_nofail() to
qdev_new()/qdev_realize_and_unref(); recent commit "qdev: New
qdev_new(), qdev_realize(), etc." explains why.
ISA devices use qdev_create() through isa_create() and
isa_try_create().
Provide isa_new(), isa_try_new(), and isa_realize_and_unref() for
converting ISA devices.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
include/hw/isa/isa.h | 3 +++
hw/isa/isa-bus.c | 15 +++++++++++++++
2 files changed, 18 insertions(+)
diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h
index 02c2350274..3b6215fafe 100644
--- a/include/hw/isa/isa.h
+++ b/include/hw/isa/isa.h
@@ -105,6 +105,9 @@ MemoryRegion *isa_address_space(ISADevice *dev);
MemoryRegion *isa_address_space_io(ISADevice *dev);
ISADevice *isa_create(ISABus *bus, const char *name);
ISADevice *isa_try_create(ISABus *bus, const char *name);
+ISADevice *isa_new(const char *name);
+ISADevice *isa_try_new(const char *name);
+bool isa_realize_and_unref(ISADevice *dev, ISABus *bus, Error **errp);
ISADevice *isa_create_simple(ISABus *bus, const char *name);
ISADevice *isa_vga_init(ISABus *bus);
diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c
index 1c9d7e19ab..e6412d39b4 100644
--- a/hw/isa/isa-bus.c
+++ b/hw/isa/isa-bus.c
@@ -176,6 +176,16 @@ ISADevice *isa_try_create(ISABus *bus, const char *name)
return ISA_DEVICE(dev);
}
+ISADevice *isa_new(const char *name)
+{
+ return ISA_DEVICE(qdev_new(name));
+}
+
+ISADevice *isa_try_new(const char *name)
+{
+ return ISA_DEVICE(qdev_try_new(name));
+}
+
ISADevice *isa_create_simple(ISABus *bus, const char *name)
{
ISADevice *dev;
@@ -185,6 +195,11 @@ ISADevice *isa_create_simple(ISABus *bus, const char *name)
return dev;
}
+bool isa_realize_and_unref(ISADevice *dev, ISABus *bus, Error **errp)
+{
+ return qdev_realize_and_unref(&dev->parent_obj, &bus->parent_obj, errp);
+}
+
ISADevice *isa_vga_init(ISABus *bus)
{
switch (vga_interface_type) {
--
2.26.2
next prev parent reply other threads:[~2020-06-09 16:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 16:38 [PATCH v3 00/39] qdev: Rework how we plug into the parent bus Markus Armbruster
2020-06-09 16:38 ` [PATCH v3 01/39] qdev: Rename qbus_realize() to qbus_init() Markus Armbruster
2020-06-09 16:38 ` [PATCH v3 02/39] Revert "hw/prep: realize the PCI root bus as part of the prep init" Markus Armbruster
2020-06-09 16:38 ` [PATCH v3 03/39] Revert "hw/versatile: realize the PCI root bus as part of the versatile init" Markus Armbruster
2020-06-09 16:38 ` [PATCH v3 04/39] qdev: New qdev_new(), qdev_realize(), etc Markus Armbruster
2020-06-09 16:38 ` [PATCH v3 05/39] qdev: Put qdev_new() to use with Coccinelle Markus Armbruster
2020-06-09 16:38 ` [PATCH v3 06/39] qdev: Convert to qbus_realize(), qbus_unrealize() Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 07/39] qdev: Convert to qdev_unrealize() with Coccinelle Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 08/39] qdev: Convert to qdev_unrealize() manually Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 09/39] qdev: Convert uses of qdev_create() with Coccinelle Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 10/39] qdev: Convert uses of qdev_create() manually Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 11/39] qdev: Convert uses of qdev_set_parent_bus() with Coccinelle Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 12/39] qdev: Convert uses of qdev_set_parent_bus() manually Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 13/39] pci: New pci_new(), pci_realize_and_unref() etc Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 14/39] hw/ppc: Eliminate two superfluous QOM casts Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 15/39] pci: Convert uses of pci_create() etc. with Coccinelle Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 16/39] pci: Convert uses of pci_create() etc. manually Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 17/39] pci: pci_create(), pci_create_multifunction() are now unused, drop Markus Armbruster
2020-06-09 16:39 ` Markus Armbruster [this message]
2020-06-09 16:39 ` [PATCH v3 19/39] isa: Convert uses of isa_create() with Coccinelle Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 20/39] isa: Convert uses of isa_create(), isa_try_create() manually Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 21/39] isa: isa_create(), isa_try_create() are now unused, drop Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 22/39] ssi: ssi_auto_connect_slaves() never does anything, drop Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 23/39] ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 24/39] ssi: Convert last use of ssi_create_slave_no_init() manually Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 25/39] ssi: ssi_create_slave_no_init() is now unused, drop Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 26/39] usb: New usb_new(), usb_realize_and_unref() Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 27/39] usb: Convert uses of usb_create() Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 28/39] usb: usb_create() is now unused, drop Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 29/39] usb: Eliminate usb_try_create_simple() Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 30/39] qdev: qdev_create(), qdev_try_create() are now unused, drop Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 31/39] auxbus: Rename aux_init_bus() to aux_bus_init() Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 32/39] auxbus: New aux_bus_realize(), pairing with aux_bus_init() Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 33/39] auxbus: Convert a use of qdev_set_parent_bus() Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 34/39] auxbus: Eliminate aux_create_slave() Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 35/39] qom: Tidy up a few object_initialize_child() calls Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 36/39] qom: Less verbose object_initialize_child() Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 37/39] macio: Convert use of qdev_set_parent_bus() Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 38/39] macio: Eliminate macio_init_child_obj() Markus Armbruster
2020-06-09 16:39 ` [PATCH v3 39/39] sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls Markus Armbruster
2020-06-09 16:40 ` [PATCH v3 00/39] qdev: Rework how we plug into the parent bus Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609163932.1566209-19-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).