From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
"Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
jasowang@redhat.com, cohuck@redhat.com,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Raphael Norwitz" <raphael.norwitz@nutanix.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Max Reitz" <mreitz@redhat.com>
Subject: [PATCH v2 0/7] virtio: enable VIRTIO_F_RING_PACKED for all devices
Date: Tue, 9 Jun 2020 18:02:11 +0100 [thread overview]
Message-ID: <20200609170218.246468-1-stefanha@redhat.com> (raw)
v2:
* Add libvhost-user VHOST_USER_GET_FEATURES patch to start reporting feature
bits correctly (already reviewed by Marc-André Lureau)
* Rephrase doc comments and drop vhost_get_default_features() [Jason]
* Simplify hw/core/machine.c compat props by setting packed=off on the
virtio-dev base class [Jason]
The VIRTIO 1.1 packed virtqueue layout improves performance and guest driver
support has been available since Linux v5.0. virtio-blk benchmarks show it is
beneficial for non-net devices too so I wrote patches to enable it for all
devices.
It turned out to be trickier than I expected because vhost feature negotiation
is currently not ready for new virtqueue feature bits like
VIRTIO_F_RING_PACKED.
Patch 1 fixes libqos. Patch 2 fixes libvhost-user. Patch 3 adds clarifications
to the vhost-user specification. Patches 4-6 solve the vhost feature issues in
QEMU. Finally, Patch 6 enables packed virtqueues.
Stefan Hajnoczi (7):
tests/libqos: mask out VIRTIO_F_RING_PACKED for now
libvhost-user: advertise vring features
docs: document non-net VHOST_USER_GET_FEATURES behavior
vhost: involve device backends in feature negotiation
vhost-user-blk: add VIRTIO_F_RING_PACKED feature bit
vhost-scsi: add VIRTIO_F_VERSION_1 and VIRTIO_F_RING_PACKED
virtio: enable VIRTIO_F_RING_PACKED for all devices
include/hw/virtio/vhost.h | 1 +
include/hw/virtio/virtio-gpu.h | 2 ++
include/hw/virtio/virtio.h | 2 +-
include/sysemu/cryptodev-vhost.h | 11 +++++++++++
backends/cryptodev-vhost.c | 21 +++++++++++++++++++++
contrib/libvhost-user/libvhost-user.c | 10 ++++++++++
contrib/vhost-user-blk/vhost-user-blk.c | 4 +---
hw/block/vhost-user-blk.c | 1 +
hw/core/machine.c | 4 +++-
hw/display/vhost-user-gpu.c | 18 ++++++++++++++++++
hw/display/virtio-gpu-base.c | 2 +-
hw/input/vhost-user-input.c | 11 +++++++++++
hw/scsi/vhost-scsi.c | 2 ++
hw/scsi/vhost-user-scsi.c | 2 ++
hw/virtio/vhost-user-fs.c | 6 ++++--
hw/virtio/vhost-vsock.c | 7 +++++--
hw/virtio/vhost.c | 24 ++++++++++++++++++++++++
hw/virtio/virtio-crypto.c | 3 ++-
tests/qtest/libqos/virtio.c | 3 ++-
docs/interop/vhost-user.rst | 21 +++++++++++++++++++++
20 files changed, 143 insertions(+), 12 deletions(-)
--
2.26.2
next reply other threads:[~2020-06-09 17:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 17:02 Stefan Hajnoczi [this message]
2020-06-09 17:02 ` [PATCH v2 1/7] tests/libqos: mask out VIRTIO_F_RING_PACKED for now Stefan Hajnoczi
2020-06-09 17:02 ` [PATCH v2 2/7] libvhost-user: advertise vring features Stefan Hajnoczi
2020-06-09 17:02 ` [PATCH v2 3/7] docs: document non-net VHOST_USER_GET_FEATURES behavior Stefan Hajnoczi
2020-06-10 5:01 ` Michael S. Tsirkin
2020-07-06 9:26 ` Stefan Hajnoczi
2020-06-09 17:02 ` [PATCH v2 4/7] vhost: involve device backends in feature negotiation Stefan Hajnoczi
2020-06-09 18:07 ` Michael S. Tsirkin
2020-06-10 3:21 ` Jason Wang
2020-06-10 4:15 ` Michael S. Tsirkin
2020-06-10 5:53 ` Jason Wang
2020-06-10 6:11 ` Michael S. Tsirkin
2020-06-10 6:20 ` Jason Wang
2020-07-06 10:23 ` Stefan Hajnoczi
2020-06-10 6:20 ` Michael S. Tsirkin
2020-06-09 17:02 ` [PATCH v2 5/7] vhost-user-blk: add VIRTIO_F_RING_PACKED feature bit Stefan Hajnoczi
2020-06-09 17:02 ` [PATCH v2 6/7] vhost-scsi: add VIRTIO_F_VERSION_1 and VIRTIO_F_RING_PACKED Stefan Hajnoczi
2020-06-09 17:02 ` [PATCH v2 7/7] virtio: enable VIRTIO_F_RING_PACKED for all devices Stefan Hajnoczi
2020-06-10 5:02 ` [PATCH v2 0/7] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609170218.246468-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).