qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	jasowang@redhat.com, cohuck@redhat.com,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Raphael Norwitz" <raphael.norwitz@nutanix.com>,
	"Gonglei (Arei)" <arei.gonglei@huawei.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>
Subject: [PATCH v2 1/7] tests/libqos: mask out VIRTIO_F_RING_PACKED for now
Date: Tue,  9 Jun 2020 18:02:12 +0100	[thread overview]
Message-ID: <20200609170218.246468-2-stefanha@redhat.com> (raw)
In-Reply-To: <20200609170218.246468-1-stefanha@redhat.com>

The libqos VIRTIO code does not implement the packed virtqueue layout
yet. Mask out the feature bit for now because tests have a habit of
enabling all device feature bits and we don't want packed virtqueues to
be enabled.

Later patches will enable VIRTIO_F_RING_PACKED so prepare libqos now.

Acked-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tests/qtest/libqos/virtio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/libqos/virtio.c b/tests/qtest/libqos/virtio.c
index 9aa360620c..1c3f4a0c8b 100644
--- a/tests/qtest/libqos/virtio.c
+++ b/tests/qtest/libqos/virtio.c
@@ -96,7 +96,8 @@ uint64_t qvirtio_config_readq(QVirtioDevice *d, uint64_t addr)
 
 uint64_t qvirtio_get_features(QVirtioDevice *d)
 {
-    return d->bus->get_features(d);
+    /* qvirtio does not support packed virtqueues yet */
+    return d->bus->get_features(d) & ~(1ull << VIRTIO_F_RING_PACKED);
 }
 
 void qvirtio_set_features(QVirtioDevice *d, uint64_t features)
-- 
2.26.2


  reply	other threads:[~2020-06-09 17:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 17:02 [PATCH v2 0/7] virtio: enable VIRTIO_F_RING_PACKED for all devices Stefan Hajnoczi
2020-06-09 17:02 ` Stefan Hajnoczi [this message]
2020-06-09 17:02 ` [PATCH v2 2/7] libvhost-user: advertise vring features Stefan Hajnoczi
2020-06-09 17:02 ` [PATCH v2 3/7] docs: document non-net VHOST_USER_GET_FEATURES behavior Stefan Hajnoczi
2020-06-10  5:01   ` Michael S. Tsirkin
2020-07-06  9:26     ` Stefan Hajnoczi
2020-06-09 17:02 ` [PATCH v2 4/7] vhost: involve device backends in feature negotiation Stefan Hajnoczi
2020-06-09 18:07   ` Michael S. Tsirkin
2020-06-10  3:21     ` Jason Wang
2020-06-10  4:15       ` Michael S. Tsirkin
2020-06-10  5:53         ` Jason Wang
2020-06-10  6:11           ` Michael S. Tsirkin
2020-06-10  6:20             ` Jason Wang
2020-07-06 10:23     ` Stefan Hajnoczi
2020-06-10  6:20   ` Michael S. Tsirkin
2020-06-09 17:02 ` [PATCH v2 5/7] vhost-user-blk: add VIRTIO_F_RING_PACKED feature bit Stefan Hajnoczi
2020-06-09 17:02 ` [PATCH v2 6/7] vhost-scsi: add VIRTIO_F_VERSION_1 and VIRTIO_F_RING_PACKED Stefan Hajnoczi
2020-06-09 17:02 ` [PATCH v2 7/7] virtio: enable VIRTIO_F_RING_PACKED for all devices Stefan Hajnoczi
2020-06-10  5:02 ` [PATCH v2 0/7] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609170218.246468-2-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=cohuck@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=fam@euphon.net \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=raphael.norwitz@nutanix.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).