qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Robert Foley <robert.foley@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.puhov@linaro.org, cota@braap.org, alex.bennee@linaro.org,
	robert.foley@linaro.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v3 11/13] util: Added tsan annotate for thread name.
Date: Tue,  9 Jun 2020 16:07:36 -0400	[thread overview]
Message-ID: <20200609200738.445-12-robert.foley@linaro.org> (raw)
In-Reply-To: <20200609200738.445-1-robert.foley@linaro.org>

This allows us to see the name of the thread in tsan
warning reports such as this:

  Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at:

Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Emilio G. Cota <cota@braap.org>
---
 util/qemu-thread-posix.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c
index 838980aaa5..b4c2359272 100644
--- a/util/qemu-thread-posix.c
+++ b/util/qemu-thread-posix.c
@@ -15,6 +15,7 @@
 #include "qemu/atomic.h"
 #include "qemu/notify.h"
 #include "qemu-thread-common.h"
+#include "qemu/tsan.h"
 
 static bool name_threads;
 
@@ -513,6 +514,7 @@ static void *qemu_thread_start(void *args)
 # endif
     }
 #endif
+    QEMU_TSAN_ANNOTATE_THREAD_NAME(qemu_thread_args->name);
     g_free(qemu_thread_args->name);
     g_free(qemu_thread_args);
     pthread_cleanup_push(qemu_thread_atexit_notify, NULL);
-- 
2.17.1



  parent reply	other threads:[~2020-06-09 20:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 20:07 [PATCH v3 00/13] Add Thread Sanitizer support to QEMU Robert Foley
2020-06-09 20:07 ` [PATCH v3 01/13] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext Robert Foley
2020-06-09 20:07 ` [PATCH v3 02/13] cpu: convert queued work to a QSIMPLEQ Robert Foley
2020-06-09 20:07 ` [PATCH v3 03/13] thread: add qemu_spin_destroy Robert Foley
2020-06-09 20:07 ` [PATCH v3 04/13] cputlb: destroy CPUTLB with tlb_destroy Robert Foley
2020-06-09 20:07 ` [PATCH v3 05/13] qht: call qemu_spin_destroy for head buckets Robert Foley
2020-06-09 20:07 ` [PATCH v3 06/13] tcg: call qemu_spin_destroy for tb->jmp_lock Robert Foley
2020-06-09 20:07 ` [PATCH v3 07/13] translate-all: call qemu_spin_destroy for PageDesc Robert Foley
2020-06-09 20:07 ` [PATCH v3 08/13] thread: add tsan annotations to QemuSpin Robert Foley
2020-06-09 20:07 ` [PATCH v3 09/13] tests/docker: Added docker build support for TSan Robert Foley
2020-06-09 20:07 ` [PATCH v3 10/13] include/qemu: Added tsan.h for annotations Robert Foley
2020-06-09 20:07 ` Robert Foley [this message]
2020-06-09 20:07 ` [PATCH v3 12/13] docs: Added details on TSan to testing.rst Robert Foley
2020-06-09 20:07 ` [PATCH v3 13/13] tests: Disable select tests under TSan, which hit TSan issue Robert Foley
2020-06-10 16:45 ` [PATCH v3 00/13] Add Thread Sanitizer support to QEMU Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609200738.445-12-robert.foley@linaro.org \
    --to=robert.foley@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=cota@braap.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.puhov@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).