qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, qemu-stable@nongnu.org
Subject: [PATCH] hw/vfio/pci-quirks: Fix broken legacy IGD passthrough
Date: Wed, 10 Jun 2020 05:51:02 +0200	[thread overview]
Message-ID: <20200610035102.20192-1-thuth@redhat.com> (raw)

The #ifdef CONFIG_VFIO_IGD in pci-quirks.c is not working since the
required header config-devices.h is not included, so that the legacy
IGD passthrough is currently broken. Let's include the right header
to fix this issue.

Buglink: https://bugs.launchpad.net/qemu/+bug/1882784
Fixes: 29d62771c81d8fd244a67c14a1d968c268d3fb19
       ("hw/vfio: Move the IGD quirk code to a separate file")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/vfio/pci-quirks.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
index f2155ddb1d..3158390db1 100644
--- a/hw/vfio/pci-quirks.c
+++ b/hw/vfio/pci-quirks.c
@@ -11,6 +11,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "config-devices.h"
 #include "exec/memop.h"
 #include "qemu/units.h"
 #include "qemu/error-report.h"
-- 
2.18.1



             reply	other threads:[~2020-06-10  3:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10  3:51 Thomas Huth [this message]
2020-06-10  7:31 ` [PATCH] hw/vfio/pci-quirks: Fix broken legacy IGD passthrough Philippe Mathieu-Daudé
2020-06-10  7:50   ` Thomas Huth
2020-06-10  7:53     ` Philippe Mathieu-Daudé
2020-06-10  7:59       ` Thomas Huth
2020-06-10  8:25         ` Philippe Mathieu-Daudé
2020-06-10  9:03           ` Thomas Huth
2020-06-10 10:08             ` Philippe Mathieu-Daudé
2020-06-11 17:35         ` Alex Williamson
2020-06-10 13:16     ` Laurent Vivier
2020-06-10 14:10       ` Thomas Huth
2020-08-12  8:26       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200610035102.20192-1-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).