From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Johannes Berg" <johannes.berg@intel.com>,
"David Hildenbrand" <david@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Raphael Norwitz" <raphael.norwitz@nutanix.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PULL 43/56] Support adding individual regions in libvhost-user
Date: Wed, 10 Jun 2020 00:28:08 -0400 [thread overview]
Message-ID: <20200610042613.1459309-44-mst@redhat.com> (raw)
In-Reply-To: <20200610042613.1459309-1-mst@redhat.com>
From: Raphael Norwitz <raphael.norwitz@nutanix.com>
When the VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS is enabled, qemu will
transmit memory regions to a backend individually using the new message
VHOST_USER_ADD_MEM_REG. With this change vhost-user backends built with
libvhost-user can now map in new memory regions when VHOST_USER_ADD_MEM_REG
messages are received.
Qemu only sends VHOST_USER_ADD_MEM_REG messages when the
VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS feature is negotiated, and
since it is not yet supported in libvhost-user, this new functionality
is not yet used.
Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Message-Id: <1588533678-23450-9-git-send-email-raphael.norwitz@nutanix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
contrib/libvhost-user/libvhost-user.h | 7 ++
contrib/libvhost-user/libvhost-user.c | 103 ++++++++++++++++++++++++++
2 files changed, 110 insertions(+)
diff --git a/contrib/libvhost-user/libvhost-user.h b/contrib/libvhost-user/libvhost-user.h
index 88ef40d26a..60ef7fd13e 100644
--- a/contrib/libvhost-user/libvhost-user.h
+++ b/contrib/libvhost-user/libvhost-user.h
@@ -98,6 +98,7 @@ typedef enum VhostUserRequest {
VHOST_USER_GPU_SET_SOCKET = 33,
VHOST_USER_VRING_KICK = 35,
VHOST_USER_GET_MAX_MEM_SLOTS = 36,
+ VHOST_USER_ADD_MEM_REG = 37,
VHOST_USER_MAX
} VhostUserRequest;
@@ -124,6 +125,11 @@ typedef struct VhostUserMemory {
VhostUserMemoryRegion regions[VHOST_MEMORY_MAX_NREGIONS];
} VhostUserMemory;
+typedef struct VhostUserMemRegMsg {
+ uint32_t padding;
+ VhostUserMemoryRegion region;
+} VhostUserMemRegMsg;
+
typedef struct VhostUserLog {
uint64_t mmap_size;
uint64_t mmap_offset;
@@ -176,6 +182,7 @@ typedef struct VhostUserMsg {
struct vhost_vring_state state;
struct vhost_vring_addr addr;
VhostUserMemory memory;
+ VhostUserMemRegMsg memreg;
VhostUserLog log;
VhostUserConfig config;
VhostUserVringArea area;
diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c
index 9f039b707e..d8ee7a23a3 100644
--- a/contrib/libvhost-user/libvhost-user.c
+++ b/contrib/libvhost-user/libvhost-user.c
@@ -138,6 +138,7 @@ vu_request_to_string(unsigned int req)
REQ(VHOST_USER_GPU_SET_SOCKET),
REQ(VHOST_USER_VRING_KICK),
REQ(VHOST_USER_GET_MAX_MEM_SLOTS),
+ REQ(VHOST_USER_ADD_MEM_REG),
REQ(VHOST_USER_MAX),
};
#undef REQ
@@ -662,6 +663,106 @@ generate_faults(VuDev *dev) {
return true;
}
+static bool
+vu_add_mem_reg(VuDev *dev, VhostUserMsg *vmsg) {
+ int i;
+ bool track_ramblocks = dev->postcopy_listening;
+ VhostUserMemoryRegion m = vmsg->payload.memreg.region, *msg_region = &m;
+ VuDevRegion *dev_region = &dev->regions[dev->nregions];
+ void *mmap_addr;
+
+ /*
+ * If we are in postcopy mode and we receive a u64 payload with a 0 value
+ * we know all the postcopy client bases have been recieved, and we
+ * should start generating faults.
+ */
+ if (track_ramblocks &&
+ vmsg->size == sizeof(vmsg->payload.u64) &&
+ vmsg->payload.u64 == 0) {
+ (void)generate_faults(dev);
+ return false;
+ }
+
+ DPRINT("Adding region: %d\n", dev->nregions);
+ DPRINT(" guest_phys_addr: 0x%016"PRIx64"\n",
+ msg_region->guest_phys_addr);
+ DPRINT(" memory_size: 0x%016"PRIx64"\n",
+ msg_region->memory_size);
+ DPRINT(" userspace_addr 0x%016"PRIx64"\n",
+ msg_region->userspace_addr);
+ DPRINT(" mmap_offset 0x%016"PRIx64"\n",
+ msg_region->mmap_offset);
+
+ dev_region->gpa = msg_region->guest_phys_addr;
+ dev_region->size = msg_region->memory_size;
+ dev_region->qva = msg_region->userspace_addr;
+ dev_region->mmap_offset = msg_region->mmap_offset;
+
+ /*
+ * We don't use offset argument of mmap() since the
+ * mapped address has to be page aligned, and we use huge
+ * pages.
+ */
+ if (track_ramblocks) {
+ /*
+ * In postcopy we're using PROT_NONE here to catch anyone
+ * accessing it before we userfault.
+ */
+ mmap_addr = mmap(0, dev_region->size + dev_region->mmap_offset,
+ PROT_NONE, MAP_SHARED,
+ vmsg->fds[0], 0);
+ } else {
+ mmap_addr = mmap(0, dev_region->size + dev_region->mmap_offset,
+ PROT_READ | PROT_WRITE, MAP_SHARED, vmsg->fds[0],
+ 0);
+ }
+
+ if (mmap_addr == MAP_FAILED) {
+ vu_panic(dev, "region mmap error: %s", strerror(errno));
+ } else {
+ dev_region->mmap_addr = (uint64_t)(uintptr_t)mmap_addr;
+ DPRINT(" mmap_addr: 0x%016"PRIx64"\n",
+ dev_region->mmap_addr);
+ }
+
+ close(vmsg->fds[0]);
+
+ if (track_ramblocks) {
+ /*
+ * Return the address to QEMU so that it can translate the ufd
+ * fault addresses back.
+ */
+ msg_region->userspace_addr = (uintptr_t)(mmap_addr +
+ dev_region->mmap_offset);
+
+ /* Send the message back to qemu with the addresses filled in. */
+ vmsg->fd_num = 0;
+ if (!vu_send_reply(dev, dev->sock, vmsg)) {
+ vu_panic(dev, "failed to respond to add-mem-region for postcopy");
+ return false;
+ }
+
+ DPRINT("Successfully added new region in postcopy\n");
+ dev->nregions++;
+ return false;
+
+ } else {
+ for (i = 0; i < dev->max_queues; i++) {
+ if (dev->vq[i].vring.desc) {
+ if (map_ring(dev, &dev->vq[i])) {
+ vu_panic(dev, "remapping queue %d for new memory region",
+ i);
+ }
+ }
+ }
+
+ DPRINT("Successfully added new region\n");
+ dev->nregions++;
+ vmsg_set_reply_u64(vmsg, 0);
+ return true;
+ }
+}
+
static bool
vu_set_mem_table_exec_postcopy(VuDev *dev, VhostUserMsg *vmsg)
{
@@ -1668,6 +1769,8 @@ vu_process_message(VuDev *dev, VhostUserMsg *vmsg)
return vu_handle_vring_kick(dev, vmsg);
case VHOST_USER_GET_MAX_MEM_SLOTS:
return vu_handle_get_max_memslots(dev, vmsg);
+ case VHOST_USER_ADD_MEM_REG:
+ return vu_add_mem_reg(dev, vmsg);
default:
vmsg_close_fds(vmsg);
vu_panic(dev, "Unhandled request: %d", vmsg->request);
--
MST
next prev parent reply other threads:[~2020-06-10 5:01 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 4:26 [PULL 00/56] virtio,acpi,pci: features, fixes, cleanups, tests Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 01/56] msix: allow qword MSI-X table accesses Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 02/56] diffs-allowed: add the SRAT AML to diffs-allowed Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 03/56] hw/acpi/nvdimm: add a helper to augment SRAT generation Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 04/56] tests/acpi: update expected SRAT files Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 05/56] qtest: allow DSDT acpi table changes Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 06/56] acpi: move aml builder code for rtc device Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 07/56] acpi: rtc: use a single crs range Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 08/56] acpi: serial: don't use _STA method Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 09/56] acpi: move aml builder code for serial device Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 10/56] acpi: parallel: don't use _STA method Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 11/56] acpi: move aml builder code for parallel device Michael S. Tsirkin
2020-06-10 4:26 ` [PULL 12/56] tests/acpi: update DSDT expected files Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 13/56] acpi: tpm: Do not build TCPA table for TPM 2 Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 14/56] acpi: Convert build_tpm2() to build_append* API Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 15/56] acpi: Move build_tpm2() in the generic part Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 16/56] arm/acpi: TPM2 ACPI table support Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 17/56] test/tpm-emu: include sockets and channel headers in tpm-emu header Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 18/56] tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 19/56] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 20/56] bios-tables-test: Add Q35/TPM-TIS test Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 21/56] bios-tables-test: Generate reference tables for Q35/TPM-TIS Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 22/56] virtio-balloon: fix free page hinting without an iothread Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 23/56] virtio-balloon: fix free page hinting check on unrealize Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 24/56] virtio-balloon: unref the iothread when unrealizing Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 25/56] virtio-balloon: Implement support for page poison reporting feature Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 26/56] virtio-balloon: Provide an interface for free page reporting Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 27/56] MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 28/56] hw/pci/pcie: Move hot plug capability check to pre_plug callback Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 29/56] pci: assert configuration access is within bounds Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 30/56] hw/pci-host/prep: Correct RAVEN bus bridge memory region size Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 31/56] hw/pci/pci_bridge: Correct pci_bridge_io " Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 32/56] hw/pci/pci_bridge: Use the IEC binary prefix definitions Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 33/56] hw/pci-host: " Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 34/56] char-socket: return -1 in case of disconnect during tcp_chr_write Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 35/56] vhost-user-blk: delay vhost_user_blk_disconnect Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 36/56] Add helper to populate vhost-user message regions Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 37/56] Add vhost-user helper to get MemoryRegion data Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 38/56] Add VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS Michael S. Tsirkin
2020-06-10 4:27 ` [PULL 39/56] Transmit vhost-user memory regions individually Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 40/56] Lift max memory slots limit imposed by vhost-user Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 41/56] Refactor out libvhost-user fault generation logic Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 42/56] Support ram slot configuration in libvhost-user Michael S. Tsirkin
2020-06-10 4:28 ` Michael S. Tsirkin [this message]
2020-06-10 4:28 ` [PULL 44/56] Support individual region unmap " Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 45/56] Lift max ram slots limit " Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 46/56] libvhost-user: advertise vring features Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 47/56] hw/pci: Fix crash when running QEMU with "-nic model=rocker" Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 48/56] vhost-vsock: add vhost-vsock-common abstraction Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 49/56] virtio: add vhost-user-vsock base device Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 50/56] virtio: add vhost-user-vsock-pci device Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 51/56] acpi: make build_madt() more generic Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 52/56] acpi: create acpi-common.c and move madt code Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 53/56] acpi: madt: skip pci override on pci-less systems Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 54/56] acpi: fadt: add hw-reduced sleep register support Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 55/56] acpi: ged: rename event memory region Michael S. Tsirkin
2020-06-10 4:28 ` [PULL 56/56] Fix parameter type in vhost migration log path Michael S. Tsirkin
2020-06-10 5:30 ` [PULL 00/56] virtio,acpi,pci: features, fixes, cleanups, tests no-reply
2020-06-11 18:13 ` Peter Maydell
2020-06-12 16:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610042613.1459309-44-mst@redhat.com \
--to=mst@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=johannes.berg@intel.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).