From: "Denis V. Lunev" <den@openvz.org>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, "Denis V. Lunev" <den@openvz.org>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Denis Plotnikov <dplotnikov@virtuozzo.com>,
Max Reitz <mreitz@redhat.com>
Subject: [PATCH 1/2] aio: allow to wait for coroutine pool from different coroutine
Date: Wed, 10 Jun 2020 21:58:32 +0300 [thread overview]
Message-ID: <20200610185833.10665-1-den@openvz.org> (raw)
The patch preserves the constraint that the only waiter is allowed.
The patch renames AioTaskPool->main_co to wake_co and removes
AioTaskPool->waiting flag. wake_co keeps coroutine, which is
waiting for wakeup on worker completion. Thus 'waiting' flag
in this semantics is equivalent to 'wake_co != NULL'.
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Kevin Wolf <kwolf@redhat.com>
CC: Max Reitz <mreitz@redhat.com>
CC: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
CC: Denis Plotnikov <dplotnikov@virtuozzo.com>
---
block/aio_task.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/block/aio_task.c b/block/aio_task.c
index 88989fa248..5183b0729d 100644
--- a/block/aio_task.c
+++ b/block/aio_task.c
@@ -27,11 +27,10 @@
#include "block/aio_task.h"
struct AioTaskPool {
- Coroutine *main_co;
+ Coroutine *wake_co;
int status;
int max_busy_tasks;
int busy_tasks;
- bool waiting;
};
static void coroutine_fn aio_task_co(void *opaque)
@@ -52,21 +51,21 @@ static void coroutine_fn aio_task_co(void *opaque)
g_free(task);
- if (pool->waiting) {
- pool->waiting = false;
- aio_co_wake(pool->main_co);
+ if (pool->wake_co != NULL) {
+ aio_co_wake(pool->wake_co);
+ pool->wake_co = NULL;
}
}
void coroutine_fn aio_task_pool_wait_one(AioTaskPool *pool)
{
assert(pool->busy_tasks > 0);
- assert(qemu_coroutine_self() == pool->main_co);
+ assert(pool->wake_co == NULL);
- pool->waiting = true;
+ pool->wake_co = qemu_coroutine_self();
qemu_coroutine_yield();
- assert(!pool->waiting);
+ assert(pool->wake_co == NULL);
assert(pool->busy_tasks < pool->max_busy_tasks);
}
@@ -98,7 +97,7 @@ AioTaskPool *coroutine_fn aio_task_pool_new(int max_busy_tasks)
{
AioTaskPool *pool = g_new0(AioTaskPool, 1);
- pool->main_co = qemu_coroutine_self();
+ pool->wake_co = NULL;
pool->max_busy_tasks = max_busy_tasks;
return pool;
--
2.17.1
next reply other threads:[~2020-06-10 19:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 18:58 Denis V. Lunev [this message]
2020-06-10 18:58 ` [PATCH 2/2] qcow2: improve savevm performance Denis V. Lunev
2020-06-10 19:01 ` [PATCH 2/2] qcow2: improve savevm performance - please ignore Denis V. Lunev
2020-06-10 19:01 ` [PATCH 1/2] aio: allow to wait for coroutine pool from different coroutine " Denis V. Lunev
-- strict thread matches above, loose matches on Subject: below --
2020-06-10 19:00 [PATCH v2 0/2] qcow2: seriously improve savevm performance Denis V. Lunev
2020-06-10 19:00 ` [PATCH 1/2] aio: allow to wait for coroutine pool from different coroutine Denis V. Lunev
2020-06-10 14:41 [PATCH 0/2] qcow2: seriously improve savevm performance Denis V. Lunev
2020-06-10 14:41 ` [PATCH 1/2] aio: allow to wait for coroutine pool from different coroutine Denis V. Lunev
2020-06-10 15:10 ` Vladimir Sementsov-Ogievskiy
2020-06-10 16:52 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610185833.10665-1-den@openvz.org \
--to=den@openvz.org \
--cc=dplotnikov@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).