From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: yi.y.sun@intel.com, Wei Wang <wei.w.wang@intel.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] migration: fix xbzrle encoding rate calculation
Date: Wed, 10 Jun 2020 20:07:20 +0100 [thread overview]
Message-ID: <20200610190720.GI2718@work-vm> (raw)
In-Reply-To: <d859347e-ef56-46a2-ece5-e8bcd6753f0b@linaro.org>
* Richard Henderson (richard.henderson@linaro.org) wrote:
> On 6/7/20 5:53 PM, Wei Wang wrote:
> > It's reported an error of implicit conversion from "unsigned long" to
> > "double" when compiling with Clang 10. Simply make the encoding rate 0
> > when the encoded_size is 0.
> >
> > Fixes: e460a4b1a4
> > Reported-by: Richard Henderson <richard.henderson@linaro.org>
> > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> > ---
> > migration/ram.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Queuing to a clang 10 fixes branch.
Thanks
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Dave
>
>
> r~
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2020-06-10 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 0:53 [PATCH] migration: fix xbzrle encoding rate calculation Wei Wang
2020-06-08 16:24 ` Richard Henderson
2020-06-10 16:08 ` Richard Henderson
2020-06-10 19:07 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610190720.GI2718@work-vm \
--to=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wei.w.wang@intel.com \
--cc=yi.y.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).