From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 7/9] monitor/hmp-cmds: improvements for the 'info migrate'
Date: Thu, 11 Jun 2020 19:57:47 +0100 [thread overview]
Message-ID: <20200611185747.GC2969@work-vm> (raw)
In-Reply-To: <20200603080904.997083-8-maozhongyi@cmss.chinamobile.com>
* Mao Zhongyi (maozhongyi@cmss.chinamobile.com) wrote:
> When running:
>
> (qemu) info migrate
> globals:
> store-global-state: on
> only-migratable: off
> ...
> xbzrle transferred: 640892 kbytes
> xbzrle pages: 16645936 pages
> xbzrle cache miss: 1525426
> xbzrle cache miss rate: 0.09
> xbzrle encoding rate: 91.42
> xbzrle overflow: 40896
> ...
> compression pages: 377710 pages
> compression busy: 0
> compression busy rate: 0.00
> compressed size: 463169457
> compression rate: 3.33
>
> Add units for 'xbzrle cache miss' and 'compressed size',
> make it easier to read.
>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> docs/xbzrle.txt | 2 +-
> monitor/hmp-cmds.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt
> index b431bdaf0f..385b4993f8 100644
> --- a/docs/xbzrle.txt
> +++ b/docs/xbzrle.txt
> @@ -112,7 +112,7 @@ is recommended.
> cache size: H bytes
> xbzrle transferred: I kbytes
> xbzrle pages: J pages
> - xbzrle cache miss: K
> + xbzrle cache miss: K pages
> xbzrle overflow: L
>
> xbzrle cache-miss: the number of cache misses to date - high cache-miss rate
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index e8cf72eb3a..24f3e8e44d 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -299,7 +299,7 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
> info->xbzrle_cache->bytes >> 10);
> monitor_printf(mon, "xbzrle pages: %" PRIu64 " pages\n",
> info->xbzrle_cache->pages);
> - monitor_printf(mon, "xbzrle cache miss: %" PRIu64 "\n",
> + monitor_printf(mon, "xbzrle cache miss: %" PRIu64 " pages\n",
> info->xbzrle_cache->cache_miss);
> monitor_printf(mon, "xbzrle cache miss rate: %0.2f\n",
> info->xbzrle_cache->cache_miss_rate);
> @@ -316,8 +316,8 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
> info->compression->busy);
> monitor_printf(mon, "compression busy rate: %0.2f\n",
> info->compression->busy_rate);
> - monitor_printf(mon, "compressed size: %" PRIu64 "\n",
> - info->compression->compressed_size);
> + monitor_printf(mon, "compressed size: %" PRIu64 " kbytes\n",
> + info->compression->compressed_size >> 10);
> monitor_printf(mon, "compression rate: %0.2f\n",
> info->compression->compression_rate);
> }
> --
> 2.17.1
>
>
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-06-11 18:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 8:08 [PATCH 0/9] monitor/hmp-cmds: small improvements for migration Mao Zhongyi
2020-06-03 8:08 ` [PATCH 1/9] tests/migration: mem leak fix Mao Zhongyi
2020-06-03 8:08 ` [PATCH 2/9] tests/migration: fix unreachable path in stress test Mao Zhongyi
2020-06-03 8:08 ` [PATCH 3/9] monitor/hmp-cmds: add units for migrate_parameters Mao Zhongyi
2020-06-03 8:08 ` [PATCH 4/9] monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails Mao Zhongyi
2020-06-03 8:09 ` [PATCH 5/9] monitor/hmp-cmds: delete redundant Error check before invoke hmp_handle_error() Mao Zhongyi
2020-06-11 18:52 ` Dr. David Alan Gilbert
2020-06-03 8:09 ` [PATCH 6/9] monitor/hmp-cmds: add 'goto end' to reduce duplicate code Mao Zhongyi
2020-06-11 18:56 ` Dr. David Alan Gilbert
2020-06-03 8:09 ` [PATCH 7/9] monitor/hmp-cmds: improvements for the 'info migrate' Mao Zhongyi
2020-06-11 18:57 ` Dr. David Alan Gilbert [this message]
2020-06-03 8:09 ` [PATCH 8/9] docs/xbzrle: update 'cache miss rate' and 'encoding rate' to docs Mao Zhongyi
2020-06-11 19:00 ` Dr. David Alan Gilbert
2020-06-03 8:09 ` [PATCH 9/9] migration/ram: calculate un/encoded_size only when needed Mao Zhongyi
2020-06-11 19:05 ` Dr. David Alan Gilbert
2020-06-12 3:06 ` [PATCH 9/9] migration/ram: calculate un/encoded_size only whenneeded maozy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611185747.GC2969@work-vm \
--to=dgilbert@redhat.com \
--cc=maozhongyi@cmss.chinamobile.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).