From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Esteban Bosse" <estebanbosse@gmail.com>,
qemu-arm@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Joel Stanley" <joel@jms.id.au>
Subject: [RFC PATCH v2 3/5] hw/misc/led: Add create_led_by_gpio_id() helper
Date: Fri, 12 Jun 2020 19:54:38 +0200 [thread overview]
Message-ID: <20200612175440.9901-4-f4bug@amsat.org> (raw)
In-Reply-To: <20200612175440.9901-1-f4bug@amsat.org>
Add create_led_by_gpio_id() to easily connect a LED to
a GPIO output.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/hw/misc/led.h | 14 ++++++++++++++
hw/misc/led.c | 20 ++++++++++++++++++++
2 files changed, 34 insertions(+)
diff --git a/include/hw/misc/led.h b/include/hw/misc/led.h
index 9300d4db6c..1b2bb96712 100644
--- a/include/hw/misc/led.h
+++ b/include/hw/misc/led.h
@@ -28,4 +28,18 @@ typedef struct LEDState {
uint8_t reset_state; /* TODO [GPIO_ACTIVE_LOW, GPIO_ACTIVE_HIGH] */
} LEDState;
+/**
+ * create_led_by_gpio_id: create and LED device
+ * @parent: the parent object
+ * @gpio_dev: device exporting GPIOs
+ * @gpio_id: GPIO ID of this LED
+ * @name: name of the LED
+ *
+ * This utility function creates a LED and connects it to a
+ * GPIO exported by another device.
+ */
+DeviceState *create_led_by_gpio_id(Object *parentobj,
+ DeviceState *gpio_dev, unsigned gpio_id,
+ const char *led_name);
+
#endif /* HW_MISC_LED_H */
diff --git a/hw/misc/led.c b/hw/misc/led.c
index 11c7e8bb89..36de80dd67 100644
--- a/hw/misc/led.c
+++ b/hw/misc/led.c
@@ -104,3 +104,23 @@ static void led_register_types(void)
}
type_init(led_register_types)
+
+DeviceState *create_led_by_gpio_id(Object *parentobj,
+ DeviceState *gpio_dev, unsigned gpio_id,
+ const char *led_name)
+{
+ DeviceState *dev;
+ char *name;
+
+ dev = qdev_create(NULL, TYPE_LED);
+ /* TODO set "reset_state" */
+ qdev_prop_set_string(dev, "name", led_name);
+ name = g_ascii_strdown(led_name, -1);
+ name = g_strdelimit(name, " #", '-');
+ object_property_add_child(parentobj, name, OBJECT(dev));
+ g_free(name);
+ qdev_init_nofail(dev);
+ qdev_connect_gpio_out(gpio_dev, gpio_id, qdev_get_gpio_in(dev, 0));
+
+ return dev;
+}
--
2.21.3
next prev parent reply other threads:[~2020-06-12 17:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 17:54 [RFC PATCH v2 0/5] hw/misc: Add LED device Philippe Mathieu-Daudé
2020-06-12 17:54 ` [RFC PATCH v2 1/5] hw/misc: Add a " Philippe Mathieu-Daudé
2020-06-12 18:44 ` Stefan Weil
2020-06-15 10:55 ` Dr. David Alan Gilbert
2020-06-15 11:19 ` Philippe Mathieu-Daudé
2020-06-15 11:50 ` Dr. David Alan Gilbert
2020-06-12 17:54 ` [RFC PATCH v2 2/5] hw/misc/led: Add LED_STATUS_CHANGED QAPI event Philippe Mathieu-Daudé
2020-06-15 16:05 ` Peter Maydell
2020-06-12 17:54 ` Philippe Mathieu-Daudé [this message]
2020-06-12 17:54 ` [RFC PATCH v2 4/5] hw/arm/microbit: Add a fake LED to use as proof-of-concept with Zephyr Philippe Mathieu-Daudé
2020-06-15 16:02 ` Peter Maydell
2020-06-15 16:10 ` Philippe Mathieu-Daudé
2020-06-12 17:54 ` [RFC PATCH v2 5/5] hw/arm/tosa: Use LED device for the Bluetooth led Philippe Mathieu-Daudé
2020-06-15 16:00 ` Peter Maydell
2020-06-15 16:18 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612175440.9901-4-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=estebanbosse@gmail.com \
--cc=joel@jms.id.au \
--cc=kraxel@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).