qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com,
	"Robert Foley" <robert.foley@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	richard.henderson@linaro.org, f4bug@amsat.org, cota@braap.org,
	aurelien@aurel32.net
Subject: [PATCH  v1 13/18] include/qemu: Added tsan.h for annotations.
Date: Fri, 12 Jun 2020 20:02:32 +0100	[thread overview]
Message-ID: <20200612190237.30436-14-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200612190237.30436-1-alex.bennee@linaro.org>

From: Robert Foley <robert.foley@linaro.org>

These annotations will allow us to give tsan
additional hints.  For example, we can inform
tsan about reads/writes to ignore to silence certain
classes of warnings.
We can also annotate threads so that the proper thread
naming shows up in tsan warning results.

Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Emilio G. Cota <cota@braap.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200609200738.445-11-robert.foley@linaro.org>
---
 include/qemu/tsan.h | 71 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)
 create mode 100644 include/qemu/tsan.h

diff --git a/include/qemu/tsan.h b/include/qemu/tsan.h
new file mode 100644
index 00000000000..09cc665f91d
--- /dev/null
+++ b/include/qemu/tsan.h
@@ -0,0 +1,71 @@
+#ifndef QEMU_TSAN_H
+#define QEMU_TSAN_H
+/*
+ * tsan.h
+ *
+ * This file defines macros used to give ThreadSanitizer
+ * additional information to help suppress warnings.
+ * This is necessary since TSan does not provide a header file
+ * for these annotations.  The standard way to include these
+ * is via the below macros.
+ *
+ * Annotation examples can be found here:
+ *  https://github.com/llvm/llvm-project/tree/master/compiler-rt/test/tsan
+ * annotate_happens_before.cpp or ignore_race.cpp are good places to start.
+ *
+ * The full set of annotations can be found here in tsan_interface_ann.cpp.
+ *  https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/tsan/rtl/
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+#ifdef CONFIG_TSAN
+/*
+ * Informs TSan of a happens before/after relationship.
+ */
+#define QEMU_TSAN_ANNOTATE_HAPPENS_BEFORE(addr) \
+    AnnotateHappensBefore(__FILE__, __LINE__, (void *)(addr))
+#define QEMU_TSAN_ANNOTATE_HAPPENS_AFTER(addr) \
+    AnnotateHappensAfter(__FILE__, __LINE__, (void *)(addr))
+/*
+ * Gives TSan more information about thread names it can report the
+ * name of the thread in the warning report.
+ */
+#define QEMU_TSAN_ANNOTATE_THREAD_NAME(name) \
+    AnnotateThreadName(__FILE__, __LINE__, (void *)(name))
+/*
+ * Allows defining a region of code on which TSan will not record memory READS.
+ * This has the effect of disabling race detection for this section of code.
+ */
+#define QEMU_TSAN_ANNOTATE_IGNORE_READS_BEGIN() \
+    AnnotateIgnoreReadsBegin(__FILE__, __LINE__)
+#define QEMU_TSAN_ANNOTATE_IGNORE_READS_END() \
+    AnnotateIgnoreReadsEnd(__FILE__, __LINE__)
+/*
+ * Allows defining a region of code on which TSan will not record memory
+ * WRITES.  This has the effect of disabling race detection for this
+ * section of code.
+ */
+#define QEMU_TSAN_ANNOTATE_IGNORE_WRITES_BEGIN() \
+    AnnotateIgnoreWritesBegin(__FILE__, __LINE__)
+#define QEMU_TSAN_ANNOTATE_IGNORE_WRITES_END() \
+    AnnotateIgnoreWritesEnd(__FILE__, __LINE__)
+#else
+#define QEMU_TSAN_ANNOTATE_HAPPENS_BEFORE(addr)
+#define QEMU_TSAN_ANNOTATE_HAPPENS_AFTER(addr)
+#define QEMU_TSAN_ANNOTATE_THREAD_NAME(name)
+#define QEMU_TSAN_ANNOTATE_IGNORE_READS_BEGIN()
+#define QEMU_TSAN_ANNOTATE_IGNORE_READS_END()
+#define QEMU_TSAN_ANNOTATE_IGNORE_WRITES_BEGIN()
+#define QEMU_TSAN_ANNOTATE_IGNORE_WRITES_END()
+#endif
+
+void AnnotateHappensBefore(const char *f, int l, void *addr);
+void AnnotateHappensAfter(const char *f, int l, void *addr);
+void AnnotateThreadName(const char *f, int l, char *name);
+void AnnotateIgnoreReadsBegin(const char *f, int l);
+void AnnotateIgnoreReadsEnd(const char *f, int l);
+void AnnotateIgnoreWritesBegin(const char *f, int l);
+void AnnotateIgnoreWritesEnd(const char *f, int l);
+#endif
-- 
2.20.1



  parent reply	other threads:[~2020-06-12 19:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 19:02 [PATCH v1 00/18] testing/next (tsan, dtc warnings, cross-builds) Alex Bennée
2020-06-12 19:02 ` [PATCH v1 01/18] tests/docker: bump fedora to 32 Alex Bennée
2020-06-12 19:02 ` [PATCH v1 02/18] Makefile: dtc: update, build the libfdt target Alex Bennée
2020-06-12 19:02 ` [PATCH v1 03/18] Makefile: remove old compatibility gunks Alex Bennée
2020-06-12 19:02 ` [PATCH v1 04/18] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext Alex Bennée
2020-06-12 19:02 ` [PATCH v1 05/18] cpu: convert queued work to a QSIMPLEQ Alex Bennée
2020-06-12 19:02 ` [PATCH v1 06/18] thread: add qemu_spin_destroy Alex Bennée
2020-06-12 19:02 ` [PATCH v1 07/18] cputlb: destroy CPUTLB with tlb_destroy Alex Bennée
2020-06-12 19:02 ` [PATCH v1 08/18] qht: call qemu_spin_destroy for head buckets Alex Bennée
2020-06-12 19:02 ` [PATCH v1 09/18] tcg: call qemu_spin_destroy for tb->jmp_lock Alex Bennée
2020-06-12 19:02 ` [PATCH v1 10/18] translate-all: call qemu_spin_destroy for PageDesc Alex Bennée
2020-06-12 19:02 ` [PATCH v1 11/18] thread: add tsan annotations to QemuSpin Alex Bennée
2020-06-12 19:02 ` [PATCH v1 12/18] tests/docker: Added docker build support for TSan Alex Bennée
2020-06-12 19:02 ` Alex Bennée [this message]
2020-06-12 19:02 ` [PATCH v1 14/18] util: Added tsan annotate for thread name Alex Bennée
2020-06-12 19:02 ` [PATCH v1 15/18] docs: Added details on TSan to testing.rst Alex Bennée
2020-06-12 19:02 ` [PATCH v1 16/18] tests: Disable select tests under TSan, which hit TSan issue Alex Bennée
2020-06-12 19:02 ` [PATCH v1 17/18] Revert ".shippable: temporaily disable some cross builds" Alex Bennée
2020-06-12 19:02 ` [PATCH v1 18/18] cirrus.yml: serialise make check Alex Bennée
2020-06-13  8:22   ` Li-Wen Hsu
2020-06-12 19:44 ` [PATCH v1 00/18] testing/next (tsan, dtc warnings, cross-builds) no-reply
2020-06-12 21:40   ` Philippe Mathieu-Daudé
2020-06-12 23:49     ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200612190237.30436-14-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=robert.foley@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).