qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
	eric.auger@redhat.com, pbonzini@redhat.com,
	marcandre.lureau@redhat.com, philmd@redhat.com,
	mkedzier@redhat.com, Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH v2 4/5] acpi: Enable TPM IRQ
Date: Mon, 15 Jun 2020 10:23:26 -0400	[thread overview]
Message-ID: <20200615142327.671546-5-stefanb@linux.vnet.ibm.com> (raw)
In-Reply-To: <20200615142327.671546-1-stefanb@linux.vnet.ibm.com>

From: Stefan Berger <stefanb@linux.ibm.com>

Move the TPM TIS IRQ to unused IRQ 13, which is also accepted by Windows.
Query for the TPM's irq number and enable the TPM IRQ if not zero.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
CC: Michael S. Tsirkin <mst@redhat.com>
---
 hw/i386/acpi-build.c  | 11 +++++------
 include/hw/acpi/tpm.h |  2 +-
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 900f786d08..747defe1ce 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -2021,6 +2021,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
             build_append_pci_bus_devices(scope, bus, pm->pcihp_bridge_en);
 
             if (TPM_IS_TIS_ISA(tpm)) {
+                uint8_t irq = tpm_get_irqnum(tpm);
                 if (misc->tpm_version == TPM_VERSION_2_0) {
                     dev = aml_device("TPM");
                     aml_append(dev, aml_name_decl("_HID",
@@ -2035,12 +2036,10 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
                 crs = aml_resource_template();
                 aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE,
                            TPM_TIS_ADDR_SIZE, AML_READ_WRITE));
-                /*
-                    FIXME: TPM_TIS_IRQ=5 conflicts with PNP0C0F irqs,
-                    Rewrite to take IRQ from TPM device model and
-                    fix default IRQ value there to use some unused IRQ
-                 */
-                /* aml_append(crs, aml_irq_no_flags(TPM_TIS_IRQ)); */
+
+                if (irq) {
+                    aml_append(crs, aml_irq_no_flags(irq));
+                }
                 aml_append(dev, aml_name_decl("_CRS", crs));
 
                 tpm_build_ppi_acpi(tpm, dev);
diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h
index 1a2a57a21f..063a9eb42a 100644
--- a/include/hw/acpi/tpm.h
+++ b/include/hw/acpi/tpm.h
@@ -24,7 +24,7 @@
 #define TPM_TIS_ADDR_BASE           0xFED40000
 #define TPM_TIS_ADDR_SIZE           0x5000
 
-#define TPM_TIS_IRQ                 5
+#define TPM_TIS_IRQ                 13
 
 #define TPM_TIS_NUM_LOCALITIES      5     /* per spec */
 #define TPM_TIS_LOCALITY_SHIFT      12
-- 
2.24.1



  parent reply	other threads:[~2020-06-15 14:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 14:23 [PATCH v2 0/5] tpm: Enable usage of TPM TIS with interrupts Stefan Berger
2020-06-15 14:23 ` [PATCH v2 1/5] tpm_tis: Allow lowering of IRQ also when locality is not active Stefan Berger
2020-06-15 15:06   ` Marc-André Lureau
2020-06-15 15:35     ` Stefan Berger
2020-06-16 12:31   ` Auger Eric
2020-06-15 14:23 ` [PATCH v2 2/5] tpm: Extend TPMIfClass with get_irqnum() function Stefan Berger
2020-06-15 15:11   ` Marc-André Lureau
2020-06-15 15:44     ` Stefan Berger
2020-06-16 12:45       ` Auger Eric
2020-06-15 15:54   ` Philippe Mathieu-Daudé
2020-06-15 16:19     ` Stefan Berger
2020-06-15 14:23 ` [PATCH v2 3/5] tests: Temporarily ignore DSDT table differences Stefan Berger
2020-06-15 15:12   ` Marc-André Lureau
2020-06-16 12:46   ` Auger Eric
2020-06-15 14:23 ` Stefan Berger [this message]
2020-06-15 15:13   ` [PATCH v2 4/5] acpi: Enable TPM IRQ Marc-André Lureau
2020-06-15 17:11     ` Stefan Berger
2020-06-16  7:44       ` Auger Eric
2020-06-16 13:01       ` Auger Eric
2020-06-16 14:05         ` Stefan Berger
2020-06-16 14:36           ` Auger Eric
2020-06-15 14:23 ` [PATCH v2 5/5] tests: Add updated DSDT Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200615142327.671546-5-stefanb@linux.vnet.ibm.com \
    --to=stefanb@linux.vnet.ibm.com \
    --cc=eric.auger@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mkedzier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).