From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-block@nongnu.org, "Corey Minyard" <minyard@acm.org>,
"David Hildenbrand" <david@redhat.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Max Reitz" <mreitz@redhat.com>,
qemu-arm@nongnu.org, "Joel Stanley" <joel@jms.id.au>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH 3/7] block/curl: Reduce timer precision to milli-second
Date: Tue, 16 Jun 2020 09:51:17 +0200 [thread overview]
Message-ID: <20200616075121.12837-4-f4bug@amsat.org> (raw)
In-Reply-To: <20200616075121.12837-1-f4bug@amsat.org>
The current implementation uses nano-second precision,
while the block driver is only used with a milli-second precision.
Simplify by using a milli-second based timer.
Rename the timer 'timer_ms' to have the unit explicit.
Inspired-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
block/curl.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/block/curl.c b/block/curl.c
index 6e325901dc..74950373aa 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -119,7 +119,7 @@ typedef struct CURLState
typedef struct BDRVCURLState {
CURLM *multi;
- QEMUTimer timer;
+ QEMUTimer timer_ms;
uint64_t len;
CURLState states[CURL_NUM_STATES];
char *url;
@@ -148,11 +148,10 @@ static int curl_timer_cb(CURLM *multi, long timeout_ms, void *opaque)
trace_curl_timer_cb(timeout_ms);
if (timeout_ms == -1) {
- timer_del(&s->timer);
+ timer_del(&s->timer_ms);
} else {
- int64_t timeout_ns = (int64_t)timeout_ms * 1000 * 1000;
- timer_mod(&s->timer,
- qemu_clock_get_ns(QEMU_CLOCK_REALTIME) + timeout_ns);
+ timer_mod(&s->timer_ms,
+ qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + timeout_ms);
}
return 0;
}
@@ -582,7 +581,7 @@ static void curl_detach_aio_context(BlockDriverState *bs)
}
qemu_mutex_unlock(&s->mutex);
- timer_del(&s->timer);
+ timer_del(&s->timer_ms);
}
static void curl_attach_aio_context(BlockDriverState *bs,
@@ -590,8 +589,8 @@ static void curl_attach_aio_context(BlockDriverState *bs,
{
BDRVCURLState *s = bs->opaque;
- aio_timer_init(new_context, &s->timer,
- QEMU_CLOCK_REALTIME, SCALE_NS,
+ aio_timer_init(new_context, &s->timer_ms,
+ QEMU_CLOCK_REALTIME, SCALE_MS,
curl_multi_timeout_do, s);
assert(!s->multi);
--
2.21.3
next prev parent reply other threads:[~2020-06-16 7:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 7:51 [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible Philippe Mathieu-Daudé
2020-06-16 7:51 ` [PATCH 1/7] qemu-common: Briefly document qemu_timedate_diff() unit Philippe Mathieu-Daudé
2020-06-18 5:47 ` Markus Armbruster
2020-06-22 8:50 ` Philippe Mathieu-Daudé
2020-06-16 7:51 ` [PATCH 2/7] block/qcow2: Document cache_clean_interval field holds seconds Philippe Mathieu-Daudé
2020-06-16 7:51 ` Philippe Mathieu-Daudé [this message]
2020-06-16 7:51 ` [PATCH 4/7] hw/virtio/virtio-balloon: Rename timer field including 'ms' unit Philippe Mathieu-Daudé
2020-06-16 7:57 ` David Hildenbrand
2020-06-16 7:51 ` [PATCH 5/7] hw/rtc/m48t59: Reduce timer precision to milli-second Philippe Mathieu-Daudé
2020-07-08 23:39 ` Richard Henderson
2020-06-16 7:51 ` [PATCH 6/7] hw/ipmi/ipmi_bmc_extern: " Philippe Mathieu-Daudé
2020-06-16 7:51 ` [PATCH 7/7] hw/watchdog/wdt_aspeed: Reduce timer precision to micro-second Philippe Mathieu-Daudé
2020-06-17 1:18 ` Andrew Jeffery
2020-06-17 3:41 ` Philippe Mathieu-Daudé
2020-06-22 0:21 ` Andrew Jeffery
2020-06-22 8:43 ` Philippe Mathieu-Daudé
2020-06-22 23:45 ` Andrew Jeffery
2020-07-08 23:40 ` Richard Henderson
2020-06-18 12:23 ` [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible Paolo Bonzini
2020-06-18 12:26 ` Philippe Mathieu-Daudé
2020-06-18 12:42 ` Paolo Bonzini
2020-07-08 23:37 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616075121.12837-4-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=david@redhat.com \
--cc=joel@jms.id.au \
--cc=kwolf@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=minyard@acm.org \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).