From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-block@nongnu.org, "Corey Minyard" <minyard@acm.org>,
"David Hildenbrand" <david@redhat.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Max Reitz" <mreitz@redhat.com>,
qemu-arm@nongnu.org, "Joel Stanley" <joel@jms.id.au>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH 4/7] hw/virtio/virtio-balloon: Rename timer field including 'ms' unit
Date: Tue, 16 Jun 2020 09:51:18 +0200 [thread overview]
Message-ID: <20200616075121.12837-5-f4bug@amsat.org> (raw)
In-Reply-To: <20200616075121.12837-1-f4bug@amsat.org>
To make code review easier, append the timer unit (milli-seconds)
to its variable name.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/hw/virtio/virtio-balloon.h | 2 +-
hw/virtio/virtio-balloon.c | 14 ++++++++------
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/include/hw/virtio/virtio-balloon.h b/include/hw/virtio/virtio-balloon.h
index d49fef00ce..8a85fb1b88 100644
--- a/include/hw/virtio/virtio-balloon.h
+++ b/include/hw/virtio/virtio-balloon.h
@@ -50,7 +50,7 @@ typedef struct VirtIOBalloon {
uint64_t stats[VIRTIO_BALLOON_S_NR];
VirtQueueElement *stats_vq_elem;
size_t stats_vq_offset;
- QEMUTimer *stats_timer;
+ QEMUTimer *stats_timer_ms;
IOThread *iothread;
QEMUBH *free_page_bh;
/*
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 10507b2a43..ad67cd53e4 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -197,16 +197,17 @@ static bool balloon_stats_enabled(const VirtIOBalloon *s)
static void balloon_stats_destroy_timer(VirtIOBalloon *s)
{
if (balloon_stats_enabled(s)) {
- timer_del(s->stats_timer);
- timer_free(s->stats_timer);
- s->stats_timer = NULL;
+ timer_del(s->stats_timer_ms);
+ timer_free(s->stats_timer_ms);
+ s->stats_timer_ms = NULL;
s->stats_poll_interval = 0;
}
}
static void balloon_stats_change_timer(VirtIOBalloon *s, int64_t secs)
{
- timer_mod(s->stats_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + secs * 1000);
+ timer_mod(s->stats_timer_ms,
+ qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + secs * 1000);
}
static void balloon_stats_poll_cb(void *opaque)
@@ -315,8 +316,9 @@ static void balloon_stats_set_poll_interval(Object *obj, Visitor *v,
}
/* create a new timer */
- g_assert(s->stats_timer == NULL);
- s->stats_timer = timer_new_ms(QEMU_CLOCK_VIRTUAL, balloon_stats_poll_cb, s);
+ g_assert(s->stats_timer_ms == NULL);
+ s->stats_timer_ms = timer_new_ms(QEMU_CLOCK_VIRTUAL,
+ balloon_stats_poll_cb, s);
s->stats_poll_interval = value;
balloon_stats_change_timer(s, 0);
}
--
2.21.3
next prev parent reply other threads:[~2020-06-16 7:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 7:51 [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible Philippe Mathieu-Daudé
2020-06-16 7:51 ` [PATCH 1/7] qemu-common: Briefly document qemu_timedate_diff() unit Philippe Mathieu-Daudé
2020-06-18 5:47 ` Markus Armbruster
2020-06-22 8:50 ` Philippe Mathieu-Daudé
2020-06-16 7:51 ` [PATCH 2/7] block/qcow2: Document cache_clean_interval field holds seconds Philippe Mathieu-Daudé
2020-06-16 7:51 ` [PATCH 3/7] block/curl: Reduce timer precision to milli-second Philippe Mathieu-Daudé
2020-06-16 7:51 ` Philippe Mathieu-Daudé [this message]
2020-06-16 7:57 ` [PATCH 4/7] hw/virtio/virtio-balloon: Rename timer field including 'ms' unit David Hildenbrand
2020-06-16 7:51 ` [PATCH 5/7] hw/rtc/m48t59: Reduce timer precision to milli-second Philippe Mathieu-Daudé
2020-07-08 23:39 ` Richard Henderson
2020-06-16 7:51 ` [PATCH 6/7] hw/ipmi/ipmi_bmc_extern: " Philippe Mathieu-Daudé
2020-06-16 7:51 ` [PATCH 7/7] hw/watchdog/wdt_aspeed: Reduce timer precision to micro-second Philippe Mathieu-Daudé
2020-06-17 1:18 ` Andrew Jeffery
2020-06-17 3:41 ` Philippe Mathieu-Daudé
2020-06-22 0:21 ` Andrew Jeffery
2020-06-22 8:43 ` Philippe Mathieu-Daudé
2020-06-22 23:45 ` Andrew Jeffery
2020-07-08 23:40 ` Richard Henderson
2020-06-18 12:23 ` [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible Paolo Bonzini
2020-06-18 12:26 ` Philippe Mathieu-Daudé
2020-06-18 12:42 ` Paolo Bonzini
2020-07-08 23:37 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616075121.12837-5-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=david@redhat.com \
--cc=joel@jms.id.au \
--cc=kwolf@redhat.com \
--cc=minyard@acm.org \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).