From: "Daniel P. Berrangé" <berrange@redhat.com>
To: David Edmondson <dme@dme.org>
Cc: Alexey Krasikov <alex-krasikov@yandex-team.ru>, qemu-devel@nongnu.org
Subject: Re: [PULL 3/5] crypto/linux_keyring: add 'secret_keyring' secret object.
Date: Tue, 16 Jun 2020 17:51:09 +0100 [thread overview]
Message-ID: <20200616165109.GR550360@redhat.com> (raw)
In-Reply-To: <m2y2on6jmc.fsf@dme.org>
On Tue, Jun 16, 2020 at 05:49:47PM +0100, David Edmondson wrote:
> On Monday, 2020-06-15 at 11:36:31 +01, Daniel P. Berrangé wrote:
>
> > +if test "$secret_keyring" != "no"
> > +then
> > + if test "$have_keyring" == "yes"
>
> This generates a complaint when building on Debian testing:
>
> ./configure: 6319: test: yes: unexpected operator
>
> Perhaps should be a single = ?
Yes, you are right.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-06-16 16:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 10:36 [PULL v2 0/5] Qcrypto next patches Daniel P. Berrangé
2020-06-15 10:36 ` [PULL 1/5] crypto: add "none" random provider Daniel P. Berrangé
2020-06-15 10:36 ` [PULL 2/5] crypto/secret: move main logic from 'secret' to 'secret_common' Daniel P. Berrangé
2020-06-15 10:36 ` [PULL 3/5] crypto/linux_keyring: add 'secret_keyring' secret object Daniel P. Berrangé
2020-06-16 16:49 ` David Edmondson
2020-06-16 16:51 ` Daniel P. Berrangé [this message]
2020-06-15 10:36 ` [PULL 4/5] test-crypto-secret: add 'secret_keyring' object tests Daniel P. Berrangé
2020-06-15 10:36 ` [PULL 5/5] crypto: Remove use of GCRYPT_VERSION macro Daniel P. Berrangé
2020-06-16 9:03 ` [PULL v2 0/5] Qcrypto next patches Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2020-05-29 10:35 [PULL " Daniel P. Berrangé
2020-05-29 10:35 ` [PULL 3/5] crypto/linux_keyring: add 'secret_keyring' secret object Daniel P. Berrangé
2020-06-05 11:06 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616165109.GR550360@redhat.com \
--to=berrange@redhat.com \
--cc=alex-krasikov@yandex-team.ru \
--cc=dme@dme.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).