From: P J P <ppandit@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Prasad J Pandit" <pjp@fedoraproject.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Lei Sun" <slei.casper@gmail.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Joel Stanley" <joel@jms.id.au>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH 6/6] spapr_pci: add spapr msi read method
Date: Wed, 17 Jun 2020 11:09:33 +0530 [thread overview]
Message-ID: <20200617053934.122642-7-ppandit@redhat.com> (raw)
In-Reply-To: <20200617053934.122642-1-ppandit@redhat.com>
From: Prasad J Pandit <pjp@fedoraproject.org>
Add spapr msi mmio read method to avoid NULL pointer dereference
issue.
Reported-by: Lei Sun <slei.casper@gmail.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/ppc/spapr_pci.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 83f1453096..d4193be205 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -52,6 +52,7 @@
#include "sysemu/kvm.h"
#include "sysemu/hostmem.h"
#include "sysemu/numa.h"
+#include "qemu/log.h"
/* Copied from the kernel arch/powerpc/platforms/pseries/msi.c */
#define RTAS_QUERY_FN 0
@@ -738,6 +739,12 @@ static PCIINTxRoute spapr_route_intx_pin_to_irq(void *opaque, int pin)
return route;
}
+static uint64_t spapr_msi_read(void *opaque, hwaddr addr, unsigned size)
+{
+ qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__);
+ return 0;
+}
+
/*
* MSI/MSIX memory region implementation.
* The handler handles both MSI and MSIX.
@@ -756,7 +763,7 @@ static void spapr_msi_write(void *opaque, hwaddr addr,
static const MemoryRegionOps spapr_msi_ops = {
/* There is no .read as the read result is undefined by PCI spec */
- .read = NULL,
+ .read = spapr_msi_read,
.write = spapr_msi_write,
.endianness = DEVICE_LITTLE_ENDIAN
};
--
2.26.2
next prev parent reply other threads:[~2020-06-17 5:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 5:39 [PATCH 0/6] Add various undefined MMIO r/w functions P J P
2020-06-17 5:39 ` [PATCH 1/6] hw/pci-host: add pci-intack write method P J P
2020-06-17 5:39 ` [PATCH 2/6] pci-host: add pcie-msi read method P J P
2020-06-17 5:39 ` [PATCH 3/6] vfio: add quirk device write method P J P
2020-06-17 7:33 ` Philippe Mathieu-Daudé
2020-06-17 5:39 ` [PATCH 4/6] prep: add ppc-parity " P J P
2020-06-17 7:47 ` Philippe Mathieu-Daudé
2020-06-17 5:39 ` [PATCH 5/6] nvram: add nrf51_soc flash read method P J P
2020-06-17 7:42 ` Philippe Mathieu-Daudé
2020-06-17 5:39 ` P J P [this message]
2020-06-17 7:45 ` [PATCH 6/6] spapr_pci: add spapr msi " Philippe Mathieu-Daudé
2020-06-17 6:07 ` [PATCH 0/6] Add various undefined MMIO r/w functions no-reply
2020-06-17 6:39 ` David Gibson
2020-06-17 13:06 ` Alex Williamson
2020-06-17 13:20 ` Philippe Mathieu-Daudé
2020-06-17 14:05 ` Alex Bennée
2020-06-17 14:42 ` Philippe Mathieu-Daudé
2020-06-17 15:08 ` Paolo Bonzini
2020-06-17 17:57 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617053934.122642-7-ppandit@redhat.com \
--to=ppandit@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=hpoussin@reactos.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
--cc=slei.casper@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).