qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v9 09/10] acpi: drop build_piix4_pm()
Date: Wed, 17 Jun 2020 09:11:37 +0200	[thread overview]
Message-ID: <20200617071138.11159-10-kraxel@redhat.com> (raw)
In-Reply-To: <20200617071138.11159-1-kraxel@redhat.com>

The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits)
is not used any more, remove it from DSDT.

piix4 DSDT changes:

     Scope (_SB.PCI0)
     {
-        Device (PX13)
-        {
-            Name (_ADR, 0x00010003)  // _ADR: Address
-            OperationRegion (P13C, PCI_Config, Zero, 0xFF)
-        }
-    }
-
-    Scope (_SB.PCI0)
-    {
         Device (ISA)
         {
             Name (_ADR, 0x00010000)  // _ADR: Address
             OperationRegion (P40C, PCI_Config, 0x60, 0x04)
         }
     }

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Igor Mammedow <imammedo@redhat.com>
---
 hw/i386/acpi-build.c             |  16 ----------------
 tests/data/acpi/pc/DSDT          | Bin 4972 -> 4934 bytes
 tests/data/acpi/pc/DSDT.acpihmat | Bin 6296 -> 6258 bytes
 tests/data/acpi/pc/DSDT.bridge   | Bin 6831 -> 6793 bytes
 tests/data/acpi/pc/DSDT.cphp     | Bin 5435 -> 5397 bytes
 tests/data/acpi/pc/DSDT.dimmpxm  | Bin 6625 -> 6587 bytes
 tests/data/acpi/pc/DSDT.ipmikcs  | Bin 5044 -> 5006 bytes
 tests/data/acpi/pc/DSDT.memhp    | Bin 6331 -> 6293 bytes
 tests/data/acpi/pc/DSDT.numamem  | Bin 4978 -> 4940 bytes
 9 files changed, 16 deletions(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index ffbdbee51aa8..59f1b4d89000 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1364,21 +1364,6 @@ static void build_q35_isa_bridge(Aml *table)
     aml_append(table, scope);
 }
 
-static void build_piix4_pm(Aml *table)
-{
-    Aml *dev;
-    Aml *scope;
-
-    scope =  aml_scope("_SB.PCI0");
-    dev = aml_device("PX13");
-    aml_append(dev, aml_name_decl("_ADR", aml_int(0x00010003)));
-
-    aml_append(dev, aml_operation_region("P13C", AML_PCI_CONFIG,
-                                         aml_int(0x00), 0xff));
-    aml_append(scope, dev);
-    aml_append(table, scope);
-}
-
 static void build_piix4_isa_bridge(Aml *table)
 {
     Aml *dev;
@@ -1530,7 +1515,6 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
         aml_append(dsdt, sb_scope);
 
         build_hpet_aml(dsdt);
-        build_piix4_pm(dsdt);
         build_piix4_isa_bridge(dsdt);
         build_isa_devices_aml(dsdt);
         build_piix4_pci_hotplug(dsdt);
diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT
index d9074ac8df7ff21f214a5f4a135e3d1ac2c86227..6d0aaf729ac7d64cf966621adf276534de5cc555 100644
GIT binary patch
delta 24
fcmaE(c1(@SCD<jzO_+g!asNgxF~-eqjA}vvTlfZ5

delta 62
zcmX@6_C}4%CD<h-N0@<uan(jHF-BEYz4&0K_yA{5gXkv7fCxilj(A6xARcB0MuzBy
R07GMECI+tmo8=kRg#ZJ94@3X}

diff --git a/tests/data/acpi/pc/DSDT.acpihmat b/tests/data/acpi/pc/DSDT.acpihmat
index 8d76c7c01d49087cc5efb9843a2e1d0865145017..2e5e02400b1bd2842989d395c573fc593f45503b 100644
GIT binary patch
delta 24
fcmbPX_{o6FCD<jTNP>ZZv3Dbv7~^I)#vpM3TJi>R

delta 62
zcmexlFvF0`CD<ioh6DoxW5q@;F-BEYz4&0K_yA{5gXkv7fCxilj(A6xARcB0MuzBy
R07GMECI+tmo8=jU#Q^|-4`BcR

diff --git a/tests/data/acpi/pc/DSDT.bridge b/tests/data/acpi/pc/DSDT.bridge
index 6ffae63dd8fcc4f617b9d9d57d79bd46a7253064..623c4c03585c47d4d28adc611823b7cce8f4a5c7 100644
GIT binary patch
delta 24
fcmZ2)+G)z=66_MvDaF9R$gz=2jB&FYW2PhkQA`Ea

delta 62
zcmeA)U2n?e66_MPUW$Q%@$*J5F-BEYz4&0K_yA{5gXkv7fCxilj(A6xARcB0MuzBy
R07GMECI+tmo8=j^BmoNk55)ig

diff --git a/tests/data/acpi/pc/DSDT.cphp b/tests/data/acpi/pc/DSDT.cphp
index b25bbf7dc5bbabea277d3402b90d376beb038043..e0a43ccdadae150c0f39599c85e4e21ed8fff2a4 100644
GIT binary patch
delta 24
fcmdn3HC2ntCD<iIRFr{%(PAT)7~^I)#;?KvO>hPk

delta 62
zcmbQLwOfnJCD<jzT9ko-QF$Ym7^AAHUVN}qe1Nm3L3ER3K!l+&N4%p;5Dzm0BSUmU
RfT6K769d=(&GL-jgaOQn4+H=J

diff --git a/tests/data/acpi/pc/DSDT.dimmpxm b/tests/data/acpi/pc/DSDT.dimmpxm
index 7dffca09865f1c5d4f94e67dfe308bf22a45664a..21eb065a0ee3bd96f1a2e7601aa83fefa833349a 100644
GIT binary patch
delta 24
fcmaE8yxW+|CD<iow<H4tqryfmF~-eqjI$*GULyvu

delta 62
zcmdmO{Lq-oCD<k8p(FzXBlkuwF-BEYz4&0K_yA{5gXkv7fCxilj(A6xARcB0MuzBy
S07GMECI+tmo8=kjNB{r;>kpp*

diff --git a/tests/data/acpi/pc/DSDT.ipmikcs b/tests/data/acpi/pc/DSDT.ipmikcs
index 5a039ac93c42d4b123e21d51c5799ddb42bf12a0..b8f08f266b5735fe6967d4e105ee6b3662dad7e6 100644
GIT binary patch
delta 24
fcmdm@-lxvx66_MvC(OXW7`%~7jB&FYW1bKIQlth8

delta 62
zcmeBE-=fat66_MPMVNts(QYG`7^AAHUVN}qe1Nm3L3ER3K!l+&N4%p;5Dzm0BSUmU
RfT6K769d=(&GL--LIC7(4*CE9

diff --git a/tests/data/acpi/pc/DSDT.memhp b/tests/data/acpi/pc/DSDT.memhp
index a5b60b0e9c7d77fdc770687e28502b7dc6246dcd..9a9418f4bde5fb18883c244ea956122e371ff01a 100644
GIT binary patch
delta 24
fcmdmOIMtBLCD<iosssZA<Hn6#VvL*J7)!+gS_}rG

delta 62
zcmbPgxZ9A+CD<iow*&(N<D89LVvMS)dhx+d@d3`B2GLED0TG7A9Py4WK|IV1j118Y
S0fxrTOblHAH_J1Yi30!tun&>|

diff --git a/tests/data/acpi/pc/DSDT.numamem b/tests/data/acpi/pc/DSDT.numamem
index b82e13cd12017c7197cc236d9cc161e28dcfc8b1..6eec385c2ec00544c6eaa7e19d32b2ccd5a51915 100644
GIT binary patch
delta 24
fcmeyQc1DfMCD<jzN0@<uF>@oA7~^I)MjaslS{4Qu

delta 62
zcmX@3_DPM)CD<jTNSJ|vF=Qi`7^AAHUVN}qe1Nm3L3ER3K!l+&N4%p;5Dzm0BSUmU
RfT6K769d=(&GL-8LIC%74+a1L

-- 
2.18.4



  parent reply	other threads:[~2020-06-17  7:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17  7:11 [PATCH v9 00/10] acpi: i386 tweaks Gerd Hoffmann
2020-06-17  7:11 ` [PATCH v9 01/10] acpi: bios-tables-test: show more context on asl diffs Gerd Hoffmann
2020-06-17  7:31   ` Philippe Mathieu-Daudé
2020-06-17  7:11 ` [PATCH v9 02/10] acpi: move aml builder code for floppy device Gerd Hoffmann
2020-06-17  8:40   ` Thomas Huth
2020-06-17 11:31     ` Gerd Hoffmann
2020-06-17 11:34       ` Thomas Huth
2020-06-18 20:07   ` Michael S. Tsirkin
2020-06-17  7:11 ` [PATCH v9 03/10] floppy: make isa_fdc_get_drive_max_chs static Gerd Hoffmann
2020-06-17  7:11 ` [PATCH v9 04/10] floppy: move cmos_get_fd_drive_type() from pc Gerd Hoffmann
2020-06-17  7:11 ` [PATCH v9 05/10] acpi: move aml builder code for i8042 (kbd+mouse) device Gerd Hoffmann
2020-06-18 20:05   ` Michael S. Tsirkin
2020-06-17  7:11 ` [PATCH v9 06/10] acpi: factor out fw_cfg_add_acpi_dsdt() Gerd Hoffmann
2020-06-17  7:11 ` [PATCH v9 07/10] acpi: simplify build_isa_devices_aml() Gerd Hoffmann
2020-06-17  7:11 ` [PATCH v9 08/10] acpi: drop serial/parallel enable bits from dsdt Gerd Hoffmann
2020-06-18 20:08   ` Michael S. Tsirkin
2020-06-17  7:11 ` Gerd Hoffmann [this message]
2020-06-17  7:11 ` [PATCH v9 10/10] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion Gerd Hoffmann
2020-06-17  7:24 ` [PATCH v9 00/10] acpi: i386 tweaks no-reply
2020-06-17  7:42 ` no-reply
2020-06-17  7:47 ` no-reply
2020-06-18 20:09 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617071138.11159-10-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).