From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v9 10/10] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.
Date: Wed, 17 Jun 2020 09:11:38 +0200 [thread overview]
Message-ID: <20200617071138.11159-11-kraxel@redhat.com> (raw)
In-Reply-To: <20200617071138.11159-1-kraxel@redhat.com>
Seems to be unused.
ich9 DSDT changes:
Scope (_SB.PCI0)
{
Device (ISA)
{
Name (_ADR, 0x001F0000) // _ADR: Address
OperationRegion (PIRQ, PCI_Config, 0x60, 0x0C)
- OperationRegion (LPCD, PCI_Config, 0x80, 0x02)
- Field (LPCD, AnyAcc, NoLock, Preserve)
- {
- COMA, 3,
- , 1,
- COMB, 3,
- Offset (0x01),
- LPTD, 2
- }
}
}
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 11 -----------
tests/data/acpi/q35/DSDT | Bin 7718 -> 7678 bytes
tests/data/acpi/q35/DSDT.acpihmat | Bin 9042 -> 9002 bytes
tests/data/acpi/q35/DSDT.bridge | Bin 7735 -> 7695 bytes
tests/data/acpi/q35/DSDT.cphp | Bin 8181 -> 8141 bytes
tests/data/acpi/q35/DSDT.dimmpxm | Bin 9371 -> 9331 bytes
tests/data/acpi/q35/DSDT.ipmibt | Bin 7793 -> 7753 bytes
tests/data/acpi/q35/DSDT.memhp | Bin 9077 -> 9037 bytes
tests/data/acpi/q35/DSDT.mmio64 | Bin 8848 -> 8808 bytes
tests/data/acpi/q35/DSDT.numamem | Bin 7724 -> 7684 bytes
tests/data/acpi/q35/DSDT.tis | Bin 8323 -> 8283 bytes
11 files changed, 11 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 59f1b4d89000..378515df66c5 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1340,7 +1340,6 @@ static void build_q35_isa_bridge(Aml *table)
{
Aml *dev;
Aml *scope;
- Aml *field;
scope = aml_scope("_SB.PCI0");
dev = aml_device("ISA");
@@ -1350,16 +1349,6 @@ static void build_q35_isa_bridge(Aml *table)
aml_append(dev, aml_operation_region("PIRQ", AML_PCI_CONFIG,
aml_int(0x60), 0x0C));
- aml_append(dev, aml_operation_region("LPCD", AML_PCI_CONFIG,
- aml_int(0x80), 0x02));
- field = aml_field("LPCD", AML_ANY_ACC, AML_NOLOCK, AML_PRESERVE);
- aml_append(field, aml_named_field("COMA", 3));
- aml_append(field, aml_reserved_field(1));
- aml_append(field, aml_named_field("COMB", 3));
- aml_append(field, aml_reserved_field(1));
- aml_append(field, aml_named_field("LPTD", 2));
- aml_append(dev, field);
-
aml_append(scope, dev);
aml_append(table, scope);
}
diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
index dada9bf69fc23ea9c0931029445257657fde90ce..e63676d7a63afec714debeb465ee478ea4714337 100644
GIT binary patch
delta 63
zcmZ2x^Us>gCD<k8pDY6d<LZrE^BL9D^x}h^;scyL4WgT*JcAwMIpQ5%f_NAh<QbwH
T0z88PnYa?Tcs74$)RzGOT*VQ4
delta 103
zcmexoz08KoCD<iIO^$(q@!v+S`HX&kEPC<5PVoWGo(9oPjx3(Rj`1AvjxIqw3=HxN
z(G3BfL4izM30yqU4L$+RE=*hvTujl8k{~vNv%jw+GXo=#aspC50U<6-o6j@q%K!k0
Cz!`f0
diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
index 134fcffc3036c250877a50847426b2fe6d4229d7..cd97b819824e4140d087e465d179b71775d6a494 100644
GIT binary patch
delta 63
zcmccQw#tpmCD<iIOPPUzv0@|Fd`2}jz4&0K_yA{5gXktH&tS)Rj(A6xARYz=d4}kQ
S0MDR6Cawf7p3UDGqZI)owGfy9
delta 103
zcmZ4GcFB#)CD<h-NST3w@ytf9`HX&kEPC<5PVoWGo(9oPjx3(Rj`1AvjxIqw3=HxN
z(G3BfL4izM30yqU4L$+RE=*hvTujl8k{~vNv%jw+GXo=#aspC50U<6-o6j>wD*^z5
Cjv1H$
diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
index 6be4ccde643b3bba57f827c65490fa3a328ca77e..8b0fb497dbbaeba18e9d0e1503de4396f1c230b0 100644
GIT binary patch
delta 63
zcmdmP({ID&66_MfFUP>Z=(Uk+KBJnNUVN}qe1Nm3L3ERpXRu>DN4%p;5Dx=`JVSIt
SfM-x36ITKk&*txp4l)1&84ut9
delta 103
zcmeCT*>1z-66_LUF2}&YIBz4@d`3S%7QOgjr}zM8PlM<tM;6au$9Rr-N0%TT1_pVC
z=!O8#pg<<B1TLQF2A=?D7bdO-E~e;4Nf4XC+27ZZnSl{VIRPo3fDjj^&F2{%WB^Gr
B7~lW^
diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
index d076236552c60b275bd91e59ab03ea8d96ccc9ea..d9bb414e9bf15d9b9149f38c9bb5d8b993f88650 100644
GIT binary patch
delta 63
zcmexrf7YJMCD<k8tULn)qsm6E`HX66dhx+d@d3`B2GLDYp23ds9Py4WK|Bl$@(j@p
T0iHpDOk4?EJe$8W{*wg&L=O?V
delta 103
zcmX?W|J9z$CD<k8t2_e(W5q_U`HX&kEPC<5PVoWGo(9oPjx3(Rj`1AvjxIqw3=HxN
z(G3BfL4izM30yqU4L$+RE=*hvTujl8k{~vNv%jw+GXo=#aspC50U<6-o6j@;lLY{`
CU>dpr
diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
index eeef0a4c15828b3a621aab88eafb3631ff85a960..29f19b22a38f9d8e7dc9870f0c1aa3d4470643ff 100644
GIT binary patch
delta 63
zcmbR3`PqZZCD<jTScQRs@$E*g`HX66dhx+d@d3`B2GLDYp23ds9Py4WK|Bl$@(j@p
T0iHpDOk4?EJe$8WE>QviPgW7Q
delta 103
zcmezDG24^NCD<iowh99SqvJ-d`HX&kEPC<5PVoWGo(9oPjx3(Rj`1AvjxIqw3=HxN
z(G3BfL4izM30yqU4L$+RE=*hvTujl8k{~vNv%jw+GXo=#aspC50U<6-o6j>YQ33#W
Cof)_Q
diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
index 5d89b41a1878bb0c77abda0807bcc833c7538581..e8dea1ea42af765babcb747af998b0d912abdcbd 100644
GIT binary patch
delta 63
zcmexpbJB*(CD<jzQ;vaw@!m$R`HX66dhx+d@d3`B2GLDYp23ds9Py4WK|Bl$@(j@p
T0iHpDOk4?EJe$8WR>=SWM>P>#
delta 103
zcmX?U^U;ROCD<jTP>z9t(P$&rd`3S%7QOgjr}zM8PlM<tM;6au$9Rr-N0%TT1_pVC
z=!O8#pg<<B1TLQF2A=?D7bdO-E~e;4Nf4XC+27ZZnSl{VIRPo3fDjj^&F2}bWB_NL
B8C(DW
diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
index ad0608ef4d22de894e0a72596c2b15dead384903..dca76db15b943122efd5c200cb54ce3dbc97a55f 100644
GIT binary patch
delta 63
zcmezBcGiu{CD<jzSDAr<an44r`HX66dhx+d@d3`B2GLDYp23ds9Py4WK|Bl$@(j@p
T0iHpDOk4?EJe$8W)+qu2Lp2dd
delta 103
zcmX@>_SKEcCD<jTRGEQ+@xw;0`HX&kEPC<5PVoWGo(9oPjx3(Rj`1AvjxIqw3=HxN
z(G3BfL4izM30yqU4L$+RE=*hvTujl8k{~vNv%jw+GXo=#aspC50U<6-o6j@WDFOhv
C78*zZ
diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
index b6c6946ed9812685dd71b51784900480963b54bd..6d8facd9e179140682ad5d4302f3dad14dbec342 100644
GIT binary patch
delta 63
zcmbQ>`oe|FCD<h-Ly3WbF=8Xvd`2}jz4&0K_yA{5gXktH&tS)Rj(A6xARYz=d4}kQ
T0MDR6Cawf7p3UDGXDR>yD8Ufx
delta 103
zcmaFiGQpM0CD<iof)WD*<C=|J^BMj8SoGq9o#F$WJq@Cp99cYr9pgFT9bJNW7#QRk
zq8kD{g94ej61aGx8+-zsU6{BUxR|0FB|&TkXMbNuW(Gze<piXB0zzDvHlJslsQ>_s
C2pQ`D
diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
index 9b5c962434471d63d65f027c84dfc3e6ac20e10b..737325dc3082fdf06283857811f6f5174e0ff2a9 100644
GIT binary patch
delta 63
zcmZ2u(_+Kr66_MfBFDhM7_yOTKBJnNUVN}qe1Nm3L3ERpXRu>DN4%p;5Dx=`JVSIt
SfM-x36ITKk&*txprZNEhI1j!6
delta 103
zcmZp%S!2WH66_M9BgeqNxMCyMd`3S%7QOgjr}zM8PlM<tM;6au$9Rr-N0%TT1_pVC
z=!O8#pg<<B1TLQF2A=?D7bdO-E~e;4Nf4XC+27ZZnSl{VIRPo3fDjj^&F2|SWdJ|O
B7`^}i
diff --git a/tests/data/acpi/q35/DSDT.tis b/tests/data/acpi/q35/DSDT.tis
index 7cb8d8b154f3de295669a741c9ec3ec8c67e2b2f..27ee927fc5ac05b89724c154197304c39e653269 100644
GIT binary patch
delta 63
zcmZp6yzRi{66_KZt-!#**u0TzKBJnNUVN}qe1Nm3L3ERpXRu>DN4%p;5Dx=`JVSIt
SfM-x36ITKk&*txpJ#qjggb>yM
delta 103
zcmccZ(Co<N66_MvtiZs)czq++d`3S%7QOgjr}zM8PlM<tM;6au$9Rr-N0%TT1_pVC
z=!O8#pg<<B1TLQF2A=?D7bdO-E~e;4Nf4XC+27ZZnSl{VIRPo3fDjj^&F2|=<N$};
B8P)&*
--
2.18.4
next prev parent reply other threads:[~2020-06-17 7:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 7:11 [PATCH v9 00/10] acpi: i386 tweaks Gerd Hoffmann
2020-06-17 7:11 ` [PATCH v9 01/10] acpi: bios-tables-test: show more context on asl diffs Gerd Hoffmann
2020-06-17 7:31 ` Philippe Mathieu-Daudé
2020-06-17 7:11 ` [PATCH v9 02/10] acpi: move aml builder code for floppy device Gerd Hoffmann
2020-06-17 8:40 ` Thomas Huth
2020-06-17 11:31 ` Gerd Hoffmann
2020-06-17 11:34 ` Thomas Huth
2020-06-18 20:07 ` Michael S. Tsirkin
2020-06-17 7:11 ` [PATCH v9 03/10] floppy: make isa_fdc_get_drive_max_chs static Gerd Hoffmann
2020-06-17 7:11 ` [PATCH v9 04/10] floppy: move cmos_get_fd_drive_type() from pc Gerd Hoffmann
2020-06-17 7:11 ` [PATCH v9 05/10] acpi: move aml builder code for i8042 (kbd+mouse) device Gerd Hoffmann
2020-06-18 20:05 ` Michael S. Tsirkin
2020-06-17 7:11 ` [PATCH v9 06/10] acpi: factor out fw_cfg_add_acpi_dsdt() Gerd Hoffmann
2020-06-17 7:11 ` [PATCH v9 07/10] acpi: simplify build_isa_devices_aml() Gerd Hoffmann
2020-06-17 7:11 ` [PATCH v9 08/10] acpi: drop serial/parallel enable bits from dsdt Gerd Hoffmann
2020-06-18 20:08 ` Michael S. Tsirkin
2020-06-17 7:11 ` [PATCH v9 09/10] acpi: drop build_piix4_pm() Gerd Hoffmann
2020-06-17 7:11 ` Gerd Hoffmann [this message]
2020-06-17 7:24 ` [PATCH v9 00/10] acpi: i386 tweaks no-reply
2020-06-17 7:42 ` no-reply
2020-06-17 7:47 ` no-reply
2020-06-18 20:09 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617071138.11159-11-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).