From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11B7DC433DF for ; Wed, 17 Jun 2020 09:54:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEBBF2078D for ; Wed, 17 Jun 2020 09:54:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cNM6Sniy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEBBF2078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlUli-0001QX-1y for qemu-devel@archiver.kernel.org; Wed, 17 Jun 2020 05:54:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlUl1-0000sG-Ud for qemu-devel@nongnu.org; Wed, 17 Jun 2020 05:53:23 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:29459 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jlUkz-0001XC-LG for qemu-devel@nongnu.org; Wed, 17 Jun 2020 05:53:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592387600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iiJJhgAc2Fdt1aGFbUjuvuunptQll0892YUrS4CZvzk=; b=cNM6SniyxXUneuxSWKIwdJa69IlkytrriQak4Y6W6qy+34aXPzzmYsMgMO4+UCRYlZwWfu CWP9Lq9MAxW20sstdycOcgVgQfxEOswVh6sxA1WIptyU2XqoQOgplYx3pdeIZWqsBGJMiD 9iy5cZ8QcVTiwi+VWxutd9e2ejUvmrM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-33kh4k2JNw2dZWRDRrjQ9Q-1; Wed, 17 Jun 2020 05:53:18 -0400 X-MC-Unique: 33kh4k2JNw2dZWRDRrjQ9Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 891E9872FFB for ; Wed, 17 Jun 2020 09:53:17 +0000 (UTC) Received: from work-vm (ovpn-115-47.ams2.redhat.com [10.36.115.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E42045C1C3; Wed, 17 Jun 2020 09:53:13 +0000 (UTC) Date: Wed, 17 Jun 2020 10:53:10 +0100 From: "Dr. David Alan Gilbert" To: David Hildenbrand Subject: Re: [PATCH v2] hmp: Make json format optional for qom-set Message-ID: <20200617095310.GB7075@work-vm> References: <20200610075153.33892-1-david@redhat.com> <5653183f-0d7b-fb39-5da3-868dec0fb2c2@redhat.com> <20200610103938.GF2718@work-vm> <341aaec3-d751-6c63-daec-4618bfc56ffd@redhat.com> MIME-Version: 1.0 In-Reply-To: <341aaec3-d751-6c63-daec-4618bfc56ffd@redhat.com> User-Agent: Mutt/1.14.0 (2020-05-02) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=dgilbert@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/17 01:42:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eduardo Habkost , qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * David Hildenbrand (david@redhat.com) wrote: > On 10.06.20 12:39, Dr. David Alan Gilbert wrote: > > * David Hildenbrand (david@redhat.com) wrote: > >> On 10.06.20 09:51, David Hildenbrand wrote: > >>> Commit 7d2ef6dcc1cf ("hmp: Simplify qom-set") switched to the json > >>> parser, making it possible to specify complex types. However, with this > >>> change it is no longer possible to specify proper sizes (e.g., 2G, 128M), > >>> turning the interface harder to use for properties that consume sizes. > >>> > >>> Let's switch back to the previous handling and allow to specify passing > >>> json via the "-j" parameter. > >>> > >>> Cc: Philippe Mathieu-Daudé > >>> Cc: Markus Armbruster > >>> Cc: Dr. David Alan Gilbert > >>> Cc: Paolo Bonzini > >>> Cc: "Daniel P. Berrangé" > >>> Cc: Eduardo Habkost > >>> Signed-off-by: David Hildenbrand > >>> --- > >>> v1 - v2: > >>> - keep the "value:S" as correctly noted by Paolo :) > >>> --- > >>> hmp-commands.hx | 7 ++++--- > >>> qom/qom-hmp-cmds.c | 20 ++++++++++++++++---- > >>> 2 files changed, 20 insertions(+), 7 deletions(-) > >>> > >>> diff --git a/hmp-commands.hx b/hmp-commands.hx > >>> index 28256209b5..5d12fbeebe 100644 > >>> --- a/hmp-commands.hx > >>> +++ b/hmp-commands.hx > >>> @@ -1806,9 +1806,10 @@ ERST > >>> > >>> { > >>> .name = "qom-set", > >>> - .args_type = "path:s,property:s,value:S", > >>> - .params = "path property value", > >>> - .help = "set QOM property", > >>> + .args_type = "json:-j,path:s,property:s,value:S", > >>> + .params = "[-j] path property value", > >>> + .help = "set QOM property.\n\t\t\t" > >>> + "-j: the property is specified in json format.", > >> > >> Stupid mistake: > >> > >> "-j: the value is specified in json format > > > > oops; can fix that in commit > > Perfect, let me know in case you need a respin. Thanks! I've queued this; if we can come up with something nicer to meet Markus's suggestions that would be great, but for now we get the functionality back. > > -- > Thanks, > > David / dhildenb > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK