From: Jon Doron <arilou@gmail.com>
To: qemu-devel@nongnu.org
Cc: mail@maciej.szmigiero.name, Jon Doron <arilou@gmail.com>,
rvkagan@yandex-team.ru, imammedo@redhat.com, pbonzini@redhat.com,
vkuznets@redhat.com
Subject: [PATCH v1 1/3] hyperv: vmbus: Remove the 2nd IRQ
Date: Wed, 17 Jun 2020 14:03:02 +0300 [thread overview]
Message-ID: <20200617110304.636666-2-arilou@gmail.com> (raw)
In-Reply-To: <20200617110304.636666-1-arilou@gmail.com>
It seems like Windows does not really require 2 IRQs to have a
functioning VMBus.
Signed-off-by: Jon Doron <arilou@gmail.com>
---
hw/hyperv/vmbus.c | 1 -
hw/i386/acpi-build.c | 2 --
include/hw/hyperv/vmbus-bridge.h | 1 -
3 files changed, 4 deletions(-)
diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c
index f371240176..1a3738a03b 100644
--- a/hw/hyperv/vmbus.c
+++ b/hw/hyperv/vmbus.c
@@ -2742,7 +2742,6 @@ static const VMStateDescription vmstate_vmbus_bridge = {
static Property vmbus_bridge_props[] = {
DEFINE_PROP_UINT8("irq0", VMBusBridge, irq0, 7),
- DEFINE_PROP_UINT8("irq1", VMBusBridge, irq1, 13),
DEFINE_PROP_END_OF_LIST()
};
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 900f786d08..dce680e97c 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1083,8 +1083,6 @@ static Aml *build_vmbus_device_aml(VMBusBridge *vmbus_bridge)
crs = aml_resource_template();
aml_append(crs, aml_irq_no_flags(vmbus_bridge->irq0));
- /* FIXME: newer HyperV gets by with only one IRQ */
- aml_append(crs, aml_irq_no_flags(vmbus_bridge->irq1));
aml_append(dev, aml_name_decl("_CRS", crs));
return dev;
diff --git a/include/hw/hyperv/vmbus-bridge.h b/include/hw/hyperv/vmbus-bridge.h
index c0a06d832c..0369dabc03 100644
--- a/include/hw/hyperv/vmbus-bridge.h
+++ b/include/hw/hyperv/vmbus-bridge.h
@@ -20,7 +20,6 @@ typedef struct VMBusBridge {
SysBusDevice parent_obj;
uint8_t irq0;
- uint8_t irq1;
VMBus *bus;
} VMBusBridge;
--
2.24.1
next prev parent reply other threads:[~2020-06-17 11:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 11:03 [PATCH v1 0/3] hyperv: vmbus: ACPI various corrections Jon Doron
2020-06-17 11:03 ` Jon Doron [this message]
2020-06-17 11:03 ` [PATCH v1 2/3] i386: acpi: vmbus: Add _ADR definition Jon Doron
2020-06-17 11:03 ` [PATCH v1 3/3] acpi: i386: Move VMBus DSDT entry to SB Jon Doron
2020-06-17 12:02 ` [PATCH v1 0/3] hyperv: vmbus: ACPI various corrections no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617110304.636666-2-arilou@gmail.com \
--to=arilou@gmail.com \
--cc=imammedo@redhat.com \
--cc=mail@maciej.szmigiero.name \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rvkagan@yandex-team.ru \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).