From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3070FC433DF for ; Wed, 17 Jun 2020 17:55:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF76821527 for ; Wed, 17 Jun 2020 17:55:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VwhsHfMh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF76821527 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlcI1-0008D0-81 for qemu-devel@archiver.kernel.org; Wed, 17 Jun 2020 13:55:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlcHE-0007Bh-80 for qemu-devel@nongnu.org; Wed, 17 Jun 2020 13:55:08 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:23101 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jlcHC-0000Td-0y for qemu-devel@nongnu.org; Wed, 17 Jun 2020 13:55:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592416504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9uliBsP0an46gPx+oD2wPLvOfI9JPxFlPTJ+G83rjdw=; b=VwhsHfMhCN1p2yzqf7hA0xVzF6E8Q/yrUuYAJqtshHfEDS+FS3uaVvZah2YbSX8DOtha7C VWJoQB0wHE9kp0S3j7p6n7kmrnAPWu/f8TVXyLGtYl2v+0ZyLLpJdvXTAIoMhm0PcVLzb5 ZD5J/mRSf1vHFXE95VwwQCthnUfyNyA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-TpG8KuHNP8KlmTijxJmZOA-1; Wed, 17 Jun 2020 13:55:01 -0400 X-MC-Unique: TpG8KuHNP8KlmTijxJmZOA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 49F42BFC0; Wed, 17 Jun 2020 17:55:00 +0000 (UTC) Received: from work-vm (ovpn-115-47.ams2.redhat.com [10.36.115.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E11E8512FE; Wed, 17 Jun 2020 17:54:53 +0000 (UTC) Date: Wed, 17 Jun 2020 18:54:50 +0100 From: "Dr. David Alan Gilbert" To: David Hildenbrand Subject: Re: [PATCH v4 13/21] hmp: Handle virtio-mem when printing memory device info Message-ID: <20200617175450.GK2776@work-vm> References: <20200610115419.51688-1-david@redhat.com> <20200610115419.51688-14-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200610115419.51688-14-david@redhat.com> User-Agent: Mutt/1.14.0 (2020-05-02) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Received-SPF: pass client-ip=207.211.31.81; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/17 01:42:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , kvm@vger.kernel.org, "Michael S . Tsirkin" , qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * David Hildenbrand (david@redhat.com) wrote: > Print the memory device info just like for other memory devices. > > Cc: "Dr. David Alan Gilbert" > Cc: "Michael S. Tsirkin" > Signed-off-by: David Hildenbrand Reviewed-by: Dr. David Alan Gilbert > --- > monitor/hmp-cmds.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index 9c61e769ca..afc9a28069 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -1818,6 +1818,7 @@ void hmp_info_memory_devices(Monitor *mon, const QDict *qdict) > MemoryDeviceInfoList *info_list = qmp_query_memory_devices(&err); > MemoryDeviceInfoList *info; > VirtioPMEMDeviceInfo *vpi; > + VirtioMEMDeviceInfo *vmi; > MemoryDeviceInfo *value; > PCDIMMDeviceInfo *di; > > @@ -1852,6 +1853,21 @@ void hmp_info_memory_devices(Monitor *mon, const QDict *qdict) > monitor_printf(mon, " size: %" PRIu64 "\n", vpi->size); > monitor_printf(mon, " memdev: %s\n", vpi->memdev); > break; > + case MEMORY_DEVICE_INFO_KIND_VIRTIO_MEM: > + vmi = value->u.virtio_mem.data; > + monitor_printf(mon, "Memory device [%s]: \"%s\"\n", > + MemoryDeviceInfoKind_str(value->type), > + vmi->id ? vmi->id : ""); > + monitor_printf(mon, " memaddr: 0x%" PRIx64 "\n", vmi->memaddr); > + monitor_printf(mon, " node: %" PRId64 "\n", vmi->node); > + monitor_printf(mon, " requested-size: %" PRIu64 "\n", > + vmi->requested_size); > + monitor_printf(mon, " size: %" PRIu64 "\n", vmi->size); > + monitor_printf(mon, " max-size: %" PRIu64 "\n", vmi->max_size); > + monitor_printf(mon, " block-size: %" PRIu64 "\n", > + vmi->block_size); > + monitor_printf(mon, " memdev: %s\n", vmi->memdev); > + break; > default: > g_assert_not_reached(); > } > -- > 2.26.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK