qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, david@redhat.com, lvivier@redhat.com,
	maozhongyi@cmss.chinamobile.com, mreitz@redhat.com,
	pannengyuan@huawei.com
Cc: stefanha@redhat.com, quintela@redhat.com
Subject: [PULL 07/12] monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails
Date: Wed, 17 Jun 2020 19:37:28 +0100	[thread overview]
Message-ID: <20200617183733.186168-8-dgilbert@redhat.com> (raw)
In-Reply-To: <20200617183733.186168-1-dgilbert@redhat.com>

From: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>

Although 'migrate_set_downtime' has been deprecated and replaced
with 'migrate_set_parameter downtime_limit', it has not been
completely eliminated, possibly due to compatibility with older
versions. I think as long as this old parameter is running, we
should report appropriate message when something goes wrong, not
be silent.

before:
(qemu) migrate_set_downtime -1
(qemu)

after:
(qemu) migrate_set_downtime -1
Error: Parameter 'downtime_limit' expects an integer in the range of 0 to 2000 seconds

Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20200603080904.997083-5-maozhongyi@cmss.chinamobile.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 monitor/hmp-cmds.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 2c630ec88d..a704b3469a 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1189,8 +1189,11 @@ void hmp_migrate_pause(Monitor *mon, const QDict *qdict)
 /* Kept for backwards compatibility */
 void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict)
 {
+    Error *err = NULL;
+
     double value = qdict_get_double(qdict, "value");
-    qmp_migrate_set_downtime(value, NULL);
+    qmp_migrate_set_downtime(value, &err);
+    hmp_handle_error(mon, err);
 }
 
 void hmp_migrate_set_cache_size(Monitor *mon, const QDict *qdict)
-- 
2.26.2



  parent reply	other threads:[~2020-06-17 18:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17 18:37 [PULL 00/12] migration, HMP and virtiofs queue Dr. David Alan Gilbert (git)
2020-06-17 18:37 ` [PULL 01/12] virtiofsd: Whitelist fchmod Dr. David Alan Gilbert (git)
2020-06-17 18:37 ` [PULL 02/12] qom-hmp-cmds: fix a memleak in hmp_qom_get Dr. David Alan Gilbert (git)
2020-06-17 18:37 ` [PULL 03/12] hmp: Make json format optional for qom-set Dr. David Alan Gilbert (git)
2020-06-17 18:37 ` [PULL 04/12] tests/migration: mem leak fix Dr. David Alan Gilbert (git)
2020-06-17 18:37 ` [PULL 05/12] tests/migration: fix unreachable path in stress test Dr. David Alan Gilbert (git)
2020-06-17 18:37 ` [PULL 06/12] monitor/hmp-cmds: add units for migrate_parameters Dr. David Alan Gilbert (git)
2020-06-17 18:37 ` Dr. David Alan Gilbert (git) [this message]
2020-06-17 18:37 ` [PULL 08/12] monitor/hmp-cmds: delete redundant Error check before invoke hmp_handle_error() Dr. David Alan Gilbert (git)
2020-06-17 18:37 ` [PULL 09/12] monitor/hmp-cmds: add 'goto end' to reduce duplicate code Dr. David Alan Gilbert (git)
2020-06-17 18:37 ` [PULL 10/12] monitor/hmp-cmds: improvements for the 'info migrate' Dr. David Alan Gilbert (git)
2020-06-17 18:37 ` [PULL 11/12] docs/xbzrle: update 'cache miss rate' and 'encoding rate' to docs Dr. David Alan Gilbert (git)
2020-06-17 18:37 ` [PULL 12/12] migration: fix multifd_send_pages() next channel Dr. David Alan Gilbert (git)
2020-06-17 19:09 ` [PULL 00/12] migration, HMP and virtiofs queue no-reply
2020-06-18 15:51 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617183733.186168-8-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=david@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=maozhongyi@cmss.chinamobile.com \
    --cc=mreitz@redhat.com \
    --cc=pannengyuan@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).