* [PATCH 1/1] docs/s390x: fix vfio-ap device_del description
@ 2020-06-17 16:06 Christian Borntraeger
2020-06-17 16:07 ` Christian Borntraeger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Christian Borntraeger @ 2020-06-17 16:06 UTC (permalink / raw)
To: Peter Maydell
Cc: Thomas Huth, David Hildenbrand, Cornelia Huck, qemu-devel,
Halil Pasic, Christian Borntraeger, qemu-s390x, Richard Henderson
device_del requires an id and not a sysfsfile.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
docs/system/s390x/vfio-ap.rst | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/system/s390x/vfio-ap.rst b/docs/system/s390x/vfio-ap.rst
index 3cd84179a2df..f441df69edde 100644
--- a/docs/system/s390x/vfio-ap.rst
+++ b/docs/system/s390x/vfio-ap.rst
@@ -606,10 +606,11 @@ action.
To hot plug a vfio-ap device, use the QEMU ``device_add`` command::
- (qemu) device_add vfio-ap,sysfsdev="$path-to-mdev"
+ (qemu) device_add vfio-ap,sysfsdev="$path-to-mdev",id="$id"
Where the ``$path-to-mdev`` value specifies the absolute path to a mediated
device to which AP resources to be used by the guest have been assigned.
+``$id`` is the name value for the optional id parameter.
Note that on Linux guests, the AP devices will be created in the
``/sys/bus/ap/devices`` directory when the AP bus subsequently performs its periodic
@@ -632,10 +633,9 @@ or a prior hot plug action.
To hot unplug a vfio-ap device, use the QEMU ``device_del`` command::
- (qemu) device_del vfio-ap,sysfsdev="$path-to-mdev"
+ (qemu) device_del "id"
-Where ``$path-to-mdev`` is the same as the path specified when the vfio-ap
-device was attached to the virtual machine's ap-bus.
+Where ``$id`` is the same id that was specified at device creation.
On a Linux guest, the AP devices will be removed from the ``/sys/bus/ap/devices``
directory on the guest when the AP bus subsequently performs its periodic scan,
--
2.25.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] docs/s390x: fix vfio-ap device_del description
2020-06-17 16:06 [PATCH 1/1] docs/s390x: fix vfio-ap device_del description Christian Borntraeger
@ 2020-06-17 16:07 ` Christian Borntraeger
2020-06-17 16:17 ` Cornelia Huck
2020-06-17 17:17 ` Thomas Huth
2 siblings, 0 replies; 5+ messages in thread
From: Christian Borntraeger @ 2020-06-17 16:07 UTC (permalink / raw)
To: Tony Krowiak
Cc: Peter Maydell, Thomas Huth, David Hildenbrand, Cornelia Huck,
qemu-devel, Halil Pasic, qemu-s390x, Richard Henderson
wrong Person on to, I wanted to send this to Tony.
On 17.06.20 18:06, Christian Borntraeger wrote:
> device_del requires an id and not a sysfsfile.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> docs/system/s390x/vfio-ap.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/docs/system/s390x/vfio-ap.rst b/docs/system/s390x/vfio-ap.rst
> index 3cd84179a2df..f441df69edde 100644
> --- a/docs/system/s390x/vfio-ap.rst
> +++ b/docs/system/s390x/vfio-ap.rst
> @@ -606,10 +606,11 @@ action.
>
> To hot plug a vfio-ap device, use the QEMU ``device_add`` command::
>
> - (qemu) device_add vfio-ap,sysfsdev="$path-to-mdev"
> + (qemu) device_add vfio-ap,sysfsdev="$path-to-mdev",id="$id"
>
> Where the ``$path-to-mdev`` value specifies the absolute path to a mediated
> device to which AP resources to be used by the guest have been assigned.
> +``$id`` is the name value for the optional id parameter.
>
> Note that on Linux guests, the AP devices will be created in the
> ``/sys/bus/ap/devices`` directory when the AP bus subsequently performs its periodic
> @@ -632,10 +633,9 @@ or a prior hot plug action.
>
> To hot unplug a vfio-ap device, use the QEMU ``device_del`` command::
>
> - (qemu) device_del vfio-ap,sysfsdev="$path-to-mdev"
> + (qemu) device_del "id"
>
> -Where ``$path-to-mdev`` is the same as the path specified when the vfio-ap
> -device was attached to the virtual machine's ap-bus.
> +Where ``$id`` is the same id that was specified at device creation.
>
> On a Linux guest, the AP devices will be removed from the ``/sys/bus/ap/devices``
> directory on the guest when the AP bus subsequently performs its periodic scan,
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] docs/s390x: fix vfio-ap device_del description
2020-06-17 16:06 [PATCH 1/1] docs/s390x: fix vfio-ap device_del description Christian Borntraeger
2020-06-17 16:07 ` Christian Borntraeger
@ 2020-06-17 16:17 ` Cornelia Huck
2020-06-17 17:17 ` Thomas Huth
2 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2020-06-17 16:17 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Tony Krowiak, Peter Maydell, Thomas Huth, David Hildenbrand,
qemu-devel, Halil Pasic, qemu-s390x, Richard Henderson
On Wed, 17 Jun 2020 18:06:04 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> device_del requires an id and not a sysfsfile.
Fixes: bac03ec72f1b ("s390x/vfio-ap: document hot plug/unplug of vfio-ap device")
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> docs/system/s390x/vfio-ap.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Looks correct to me, will pick when I get an ack/r-b.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] docs/s390x: fix vfio-ap device_del description
2020-06-17 16:06 [PATCH 1/1] docs/s390x: fix vfio-ap device_del description Christian Borntraeger
2020-06-17 16:07 ` Christian Borntraeger
2020-06-17 16:17 ` Cornelia Huck
@ 2020-06-17 17:17 ` Thomas Huth
2020-06-18 10:35 ` Cornelia Huck
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2020-06-17 17:17 UTC (permalink / raw)
To: Christian Borntraeger, Peter Maydell
Cc: David Hildenbrand, Cornelia Huck, qemu-devel, Halil Pasic,
qemu-s390x, Richard Henderson
On 17/06/2020 18.06, Christian Borntraeger wrote:
> device_del requires an id and not a sysfsfile.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> docs/system/s390x/vfio-ap.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/docs/system/s390x/vfio-ap.rst b/docs/system/s390x/vfio-ap.rst
> index 3cd84179a2df..f441df69edde 100644
> --- a/docs/system/s390x/vfio-ap.rst
> +++ b/docs/system/s390x/vfio-ap.rst
> @@ -606,10 +606,11 @@ action.
>
> To hot plug a vfio-ap device, use the QEMU ``device_add`` command::
>
> - (qemu) device_add vfio-ap,sysfsdev="$path-to-mdev"
> + (qemu) device_add vfio-ap,sysfsdev="$path-to-mdev",id="$id"
>
> Where the ``$path-to-mdev`` value specifies the absolute path to a mediated
> device to which AP resources to be used by the guest have been assigned.
> +``$id`` is the name value for the optional id parameter.
>
> Note that on Linux guests, the AP devices will be created in the
> ``/sys/bus/ap/devices`` directory when the AP bus subsequently performs its periodic
> @@ -632,10 +633,9 @@ or a prior hot plug action.
>
> To hot unplug a vfio-ap device, use the QEMU ``device_del`` command::
>
> - (qemu) device_del vfio-ap,sysfsdev="$path-to-mdev"
> + (qemu) device_del "id"
Do you want to use $id instead of id here?
>
> -Where ``$path-to-mdev`` is the same as the path specified when the vfio-ap
> -device was attached to the virtual machine's ap-bus.
> +Where ``$id`` is the same id that was specified at device creation.
^--- ... since you use $id here.
> On a Linux guest, the AP devices will be removed from the ``/sys/bus/ap/devices``
> directory on the guest when the AP bus subsequently performs its periodic scan,
With the 1 $ question fixed:
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] docs/s390x: fix vfio-ap device_del description
2020-06-17 17:17 ` Thomas Huth
@ 2020-06-18 10:35 ` Cornelia Huck
0 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2020-06-18 10:35 UTC (permalink / raw)
To: Thomas Huth
Cc: Tony Krowiak, Peter Maydell, David Hildenbrand, qemu-devel,
Halil Pasic, Christian Borntraeger, qemu-s390x, Richard Henderson
On Wed, 17 Jun 2020 19:17:54 +0200
Thomas Huth <thuth@redhat.com> wrote:
> On 17/06/2020 18.06, Christian Borntraeger wrote:
> > device_del requires an id and not a sysfsfile.
> >
> > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > ---
> > docs/system/s390x/vfio-ap.rst | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/docs/system/s390x/vfio-ap.rst b/docs/system/s390x/vfio-ap.rst
> > index 3cd84179a2df..f441df69edde 100644
> > --- a/docs/system/s390x/vfio-ap.rst
> > +++ b/docs/system/s390x/vfio-ap.rst
> > @@ -606,10 +606,11 @@ action.
> >
> > To hot plug a vfio-ap device, use the QEMU ``device_add`` command::
> >
> > - (qemu) device_add vfio-ap,sysfsdev="$path-to-mdev"
> > + (qemu) device_add vfio-ap,sysfsdev="$path-to-mdev",id="$id"
> >
> > Where the ``$path-to-mdev`` value specifies the absolute path to a mediated
> > device to which AP resources to be used by the guest have been assigned.
> > +``$id`` is the name value for the optional id parameter.
> >
> > Note that on Linux guests, the AP devices will be created in the
> > ``/sys/bus/ap/devices`` directory when the AP bus subsequently performs its periodic
> > @@ -632,10 +633,9 @@ or a prior hot plug action.
> >
> > To hot unplug a vfio-ap device, use the QEMU ``device_del`` command::
> >
> > - (qemu) device_del vfio-ap,sysfsdev="$path-to-mdev"
> > + (qemu) device_del "id"
>
> Do you want to use $id instead of id here?
> >
> > -Where ``$path-to-mdev`` is the same as the path specified when the vfio-ap
> > -device was attached to the virtual machine's ap-bus.
> > +Where ``$id`` is the same id that was specified at device creation.
>
> ^--- ... since you use $id here.
>
> > On a Linux guest, the AP devices will be removed from the ``/sys/bus/ap/devices``
> > directory on the guest when the AP bus subsequently performs its periodic scan,
>
> With the 1 $ question fixed:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Indeed, no reason to skimp on the $s :)
Fixed up and pushed to s390-next, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-18 10:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-17 16:06 [PATCH 1/1] docs/s390x: fix vfio-ap device_del description Christian Borntraeger
2020-06-17 16:07 ` Christian Borntraeger
2020-06-17 16:17 ` Cornelia Huck
2020-06-17 17:17 ` Thomas Huth
2020-06-18 10:35 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).