qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Maxim Levitsky <mlevitsk@redhat.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [PATCH v3 0/2] iotests: Make _filter_img_create more active
Date: Thu, 18 Jun 2020 17:06:26 +0200	[thread overview]
Message-ID: <20200618150628.2169239-1-mreitz@redhat.com> (raw)

v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00748.html

v2 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00931.html


Hi,

I somehow missed running iotests where qemu-img create fails, like 111.
v2 broke it because in contrast to v1, it returned early when there is
no “, fmt=” in the line instead of filtering the filename.

So v3 keeps the fixes pertaining to Maxim’s comments, but rolls back on
that other one: If there is no “, fmt=”, the function will not bail out
early, but just keep $options empty and continue on (like v1 did).


git-backport-diff against v2:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/2:[0018] [FC] 'iotests: Make _filter_img_create more active'
002/2:[----] [--] 'iotests: filter few more luks specific create options'


Max Reitz (1):
  iotests: Make _filter_img_create more active

Maxim Levitsky (1):
  iotests: filter few more luks specific create options

 tests/qemu-iotests/087.out       |  6 +--
 tests/qemu-iotests/112.out       |  2 +-
 tests/qemu-iotests/134.out       |  2 +-
 tests/qemu-iotests/141           |  2 +-
 tests/qemu-iotests/153           |  9 ++--
 tests/qemu-iotests/158.out       |  4 +-
 tests/qemu-iotests/188.out       |  2 +-
 tests/qemu-iotests/189.out       |  4 +-
 tests/qemu-iotests/198.out       |  4 +-
 tests/qemu-iotests/263.out       |  4 +-
 tests/qemu-iotests/284.out       |  6 +--
 tests/qemu-iotests/common.filter | 93 +++++++++++++++++++++++---------
 12 files changed, 91 insertions(+), 47 deletions(-)

-- 
2.26.2



             reply	other threads:[~2020-06-18 15:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 15:06 Max Reitz [this message]
2020-06-18 15:06 ` [PATCH v3 1/2] iotests: Make _filter_img_create more active Max Reitz
2020-06-18 15:06 ` [PATCH v3 2/2] iotests: filter few more luks specific create options Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200618150628.2169239-1-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mlevitsk@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).