From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCB3DC433E0 for ; Fri, 19 Jun 2020 11:48:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 962F120CC7 for ; Fri, 19 Jun 2020 11:48:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d+Kei2qD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 962F120CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmFVg-0003L4-Op for qemu-devel@archiver.kernel.org; Fri, 19 Jun 2020 07:48:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmFUZ-0002aq-O1 for qemu-devel@nongnu.org; Fri, 19 Jun 2020 07:47:32 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27607 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jmFUW-00044P-6v for qemu-devel@nongnu.org; Fri, 19 Jun 2020 07:47:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592567247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pYG4SnP9utTFhjO7Aw9Lbue1YiNQktao7ej4RoC/CeA=; b=d+Kei2qDSEI2HdHbrav5vCh1k8wZqNI++DR61jn73IpTq7FR4I5T75rVsO6/XNDtG44/UD TaMnw+EWGRunARoIlLtNK1/KQlJffzGxswHugCrYEpvWvnkXNw9oEtnRI1pQc8vPu3gZLc t8SllOh6rd2u/H5kkaq1WgK9Dh9+M48= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-x1BUy-TGNICgKuw2FPMw3A-1; Fri, 19 Jun 2020 07:47:25 -0400 X-MC-Unique: x1BUy-TGNICgKuw2FPMw3A-1 Received: by mail-wr1-f69.google.com with SMTP id z10so4200933wrs.2 for ; Fri, 19 Jun 2020 04:47:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fDJADSxWgFpnsQhGGo+Y26ipmydYeWZDAFsCiyoQkqI=; b=V7zOCYFhLCbtg7hU+3zoyZ8po5JLX25w1B3s0AXSb9b5VBNk9TlVoOYXt90a7vMl4n rzCDJPNIFRnGXWx0wDPrRQuWUIT62ufIHsAcaxPTzZEZqxXH/Sw9wMI1k6ow0PG9ocDo 8ZZzYPf5qif15QDkah9pEOef6MTw0blEoVs7T45RaIvgROdOXdiJlG9YPetyUoV8t9Gt pZB1Htosx1u8kbnBHif88ZwrG6WC2/XRr6V9GBxrgtbYIQpQshxcNsh5mLjoWi8c2c2Q 903OnNyEUyuI0qn6SgrekN06xDorzzTiHFgGPG0eAlvB8SjtDcqkbDUzIQHXQ49nKpDL r63Q== X-Gm-Message-State: AOAM531qxSt0b94M2NphMtLWRG2QRvz0AWCmwu2K5lxaxmo8+rufRAZZ rQMEEyS6CAtvRaNHwdVyc83oFXJ0QgH5Ym5CpfgxP0a50aSKUSDRGv0sqKMFTEdxTvNsIlet1+x 7bNWd3pzkOWFXLQQ= X-Received: by 2002:a5d:4c88:: with SMTP id z8mr3631277wrs.35.1592567244403; Fri, 19 Jun 2020 04:47:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznQGnECWymBeyrfl3qGQ1U09JtwTagONqKA0qZQVXG0ytZb1kr14EWONVwdIDjj42TPeYaFA== X-Received: by 2002:a5d:4c88:: with SMTP id z8mr3631251wrs.35.1592567244208; Fri, 19 Jun 2020 04:47:24 -0700 (PDT) Received: from redhat.com (bzq-79-178-18-124.red.bezeqint.net. [79.178.18.124]) by smtp.gmail.com with ESMTPSA id u9sm6745769wme.16.2020.06.19.04.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 04:47:23 -0700 (PDT) Date: Fri, 19 Jun 2020 07:47:20 -0400 From: "Michael S. Tsirkin" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Subject: Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests Message-ID: <20200619074630-mutt-send-email-mst@kernel.org> References: <20200619020602.118306-1-david@gibson.dropbear.id.au> <20200619020602.118306-10-david@gibson.dropbear.id.au> <20200619101245.GC700896@redhat.com> <20200619074432-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: <20200619074432-mutt-send-email-mst@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=mst@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/19 05:19:18 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pair@us.ibm.com, brijesh.singh@amd.com, frankja@linux.ibm.com, kvm@vger.kernel.org, david@redhat.com, cohuck@redhat.com, qemu-devel@nongnu.org, Eduardo Habkost , dgilbert@redhat.com, pasic@linux.ibm.com, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com, Richard Henderson , mdroth@linux.vnet.ibm.com, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jun 19, 2020 at 07:46:14AM -0400, Michael S. Tsirkin wrote: > On Fri, Jun 19, 2020 at 11:12:45AM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 19, 2020 at 12:06:02PM +1000, David Gibson wrote: > > > The default behaviour for virtio devices is not to use the platforms normal > > > DMA paths, but instead to use the fact that it's running in a hypervisor > > > to directly access guest memory. That doesn't work if the guest's memory > > > is protected from hypervisor access, such as with AMD's SEV or POWER's PEF. > > > > > > So, if a host trust limitation mechanism is enabled, then apply the > > > iommu_platform=on option so it will go through normal DMA mechanisms. > > > Those will presumably have some way of marking memory as shared with the > > > hypervisor or hardware so that DMA will work. > > > > > > Signed-off-by: David Gibson > > > --- > > > hw/core/machine.c | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > > index a71792bc16..8dfc1bb3f8 100644 > > > --- a/hw/core/machine.c > > > +++ b/hw/core/machine.c > > > @@ -28,6 +28,8 @@ > > > #include "hw/mem/nvdimm.h" > > > #include "migration/vmstate.h" > > > #include "exec/host-trust-limitation.h" > > > +#include "hw/virtio/virtio.h" > > > +#include "hw/virtio/virtio-pci.h" > > > > > > GlobalProperty hw_compat_5_0[] = { > > > { "virtio-balloon-device", "page-poison", "false" }, > > > @@ -1165,6 +1167,15 @@ void machine_run_board_init(MachineState *machine) > > > * areas. > > > */ > > > machine_set_mem_merge(OBJECT(machine), false, &error_abort); > > > + > > > + /* > > > + * Virtio devices can't count on directly accessing guest > > > + * memory, so they need iommu_platform=on to use normal DMA > > > + * mechanisms. That requires disabling legacy virtio support > > > + * for virtio pci devices > > > + */ > > > + object_register_sugar_prop(TYPE_VIRTIO_PCI, "disable-legacy", "on"); > > > + object_register_sugar_prop(TYPE_VIRTIO_DEVICE, "iommu_platform", "on"); > > > } > > > > Silently changing the user's request configuration like this is a bad idea. > > The "disable-legacy" option in particular is undesirable as that switches > > the device to virtio-1.0 only mode, which exposes a different PCI ID to > > the guest. > > > > If some options are incompatible with encryption, then we should raise a > > fatal error at startup, so applications/admins are aware that their requested > > config is broken. > > > > Regards, > > Daniel > > Agreed - my suggestion is an on/off/auto property, auto value > changes automatically, on/off is validated. In fact should we extend all bit properties to allow an auto value? > > > -- > > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > > |: https://libvirt.org -o- https://fstop138.berrange.com :| > > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|