From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org
Subject: [PATCH 2/2] qemu-storage-daemon: add missing cleanup calls
Date: Fri, 19 Jun 2020 11:11:32 +0100 [thread overview]
Message-ID: <20200619101132.2401756-3-stefanha@redhat.com> (raw)
In-Reply-To: <20200619101132.2401756-1-stefanha@redhat.com>
Several components used by qemu-storage-daemon have cleanup functions
that aren't called. Keep the "valgrind --leak-check=full" as clean as
possible by invoking the necessary cleanup functions.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
qemu-storage-daemon.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/qemu-storage-daemon.c b/qemu-storage-daemon.c
index a01cbd6371..7e9b0e0d3f 100644
--- a/qemu-storage-daemon.c
+++ b/qemu-storage-daemon.c
@@ -335,5 +335,9 @@ int main(int argc, char *argv[])
main_loop_wait(false);
}
+ monitor_cleanup();
+ qemu_chr_cleanup();
+ user_creatable_cleanup();
+
return EXIT_SUCCESS;
}
--
2.26.2
next prev parent reply other threads:[~2020-06-19 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 10:11 [PATCH 0/2] qemu-storage-daemon: memory leak and --object opts fixes Stefan Hajnoczi
2020-06-19 10:11 ` [PATCH 1/2] qemu-storage-daemon: remember to add qemu_object_opts Stefan Hajnoczi
2020-06-19 10:11 ` Stefan Hajnoczi [this message]
2020-06-19 11:15 ` [PATCH 0/2] qemu-storage-daemon: memory leak and --object opts fixes no-reply
2020-06-19 12:16 ` Stefan Hajnoczi
2020-06-19 14:19 ` Eric Blake
2020-06-23 11:56 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619101132.2401756-3-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).