From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Geoffrey McRae <geoff@hostfission.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [PULL 3/7] audio/jack: remove invalid set of input support bool
Date: Fri, 19 Jun 2020 15:17:37 +0200 [thread overview]
Message-ID: <20200619131741.10857-4-kraxel@redhat.com> (raw)
In-Reply-To: <20200619131741.10857-1-kraxel@redhat.com>
From: Geoffrey McRae <geoff@hostfission.com>
Initial code for JACK did not support audio input and as such this
boolean was set to let QEMU know, however JACK ended up including input
support making this invalid. Further investigation shows it was invalid
to set it in the first instance anyway due to a failure on my part
understand properly what this was for when the audodev was initially
developed.
Signed-off-by: Geoffrey McRae <geoff@hostfission.com>
Message-id: 20200613040518.38172-4-geoff@hostfission.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/jackaudio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index fb8efd7af7c7..58c73444977e 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -607,9 +607,6 @@ static int qjack_thread_creator(jack_native_thread_t *thread,
static void *qjack_init(Audiodev *dev)
{
assert(dev->driver == AUDIODEV_DRIVER_JACK);
-
- dev->u.jack.has_in = false;
-
return dev;
}
--
2.18.4
next prev parent reply other threads:[~2020-06-19 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 13:17 [PULL 0/7] Audio 20200619 patches Gerd Hoffmann
2020-06-19 13:17 ` [PULL 1/7] audio/jack: fix invalid minimum buffer size check Gerd Hoffmann
2020-06-19 13:17 ` [PULL 2/7] audio/jack: remove unused stopped state Gerd Hoffmann
2020-06-19 13:17 ` Gerd Hoffmann [this message]
2020-06-19 13:17 ` [PULL 4/7] audio/jack: do not remove ports when finishing Gerd Hoffmann
2020-06-19 13:17 ` [PULL 5/7] audio/jack: honour the enable state of the audio device Gerd Hoffmann
2020-06-19 13:17 ` [PULL 6/7] audio/jack: simplify the re-init code path Gerd Hoffmann
2020-06-19 13:17 ` [PULL 7/7] hw/audio/gus: Fix registers 32-bit access Gerd Hoffmann
2020-06-19 13:56 ` [PULL 0/7] Audio 20200619 patches no-reply
2020-06-19 14:07 ` no-reply
2020-06-22 13:45 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619131741.10857-4-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=geoff@hostfission.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).